Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'RingBuffer' conflicts with definition in ARDUINO_GRAND_CENTRAL_M4 #506

Open
blurfl opened this issue May 27, 2019 · 3 comments
Open

'RingBuffer' conflicts with definition in ARDUINO_GRAND_CENTRAL_M4 #506

blurfl opened this issue May 27, 2019 · 3 comments

Comments

@blurfl
Copy link
Collaborator

blurfl commented May 27, 2019

Working on porting to the Grand Central M4, and I've run into a name collision between a definition between the definition of Ringbuffer in
Arduino15/packages/adafruit/hardware/samd/1.4.1/cores/arduino/RingBuffer.h
and in the Maslow firmware.

I'm not sure of the best workaround. Globally changing the Maslow 'RingBuffer' to 'ringBuffer' is one workaround, but is there a different or preferred way?

@BarbourSmith
Copy link
Member

Globally changing the Maslow 'RingBuffer' to 'ringBuffer' is one workaround, but is there a different or preferred way?

That sounds completely OK to me. We could even call it maslowRingBuffer if we really want to be sure of avoiding conflicts in the future.

@blurfl
Copy link
Collaborator Author

blurfl commented May 27, 2019

I'll put in a PR to name it maslowRingBuffer, thanks for the quick response!

@BarbourSmith
Copy link
Member

😀 Sounds fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants