Skip to content
This repository has been archived by the owner on Dec 26, 2021. It is now read-only.

Remove deprecation warning from waitress #150

Closed
girardinsamuel opened this issue Oct 8, 2021 · 5 comments · Fixed by #166
Closed

Remove deprecation warning from waitress #150

girardinsamuel opened this issue Oct 8, 2021 · 5 comments · Fixed by #166
Assignees
@girardinsamuel @josephmancuso
Labels
critical for release Must be done in order to release Masonite 4 question Further information is requested

Comments

@girardinsamuel
Copy link
Contributor

There is a deprecation warning that we can get rid of by explicitly do:

# ServeCommand.py

# ...
waitress.serve(application, host=host, port=port, clear_untrusted_proxy_headers=True)

In the future this parameter will be automatically set to True. So I was thinking to set this to True now but doc below confuses me. It seems that we should also provided trusted_proxy parameter ?

More info here https://docs.pylonsproject.org/projects/waitress/en/stable/arguments.html
@girardinsamuel girardinsamuel added question Further information is requested critical for release Must be done in order to release Masonite 4 labels Oct 8, 2021
@josephmancuso
Copy link
Member

I added this but still getting the deprecation warning .. is it just a warning we always see? 🤔

@girardinsamuel
Copy link
Contributor Author

I will check into the third party code and update PR if required. Maybe it will be there until release...

@josephmancuso
Copy link
Member

That's what I'm thinking

@josephmancuso
Copy link
Member

I don't think we can get rid of this for now unfortunately. We'll have to monitor for a new release

@girardinsamuel
Copy link
Contributor Author

Yep ! This might be solved in upcoming 2.0
Pylons/waitress#330

@girardinsamuel girardinsamuel mentioned this issue Oct 29, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@girardinsamuel girardinsamuel

@josephmancuso josephmancuso

Labels
critical for release Must be done in order to release Masonite 4 question Further information is requested
Projects
Masonite Ecosystem Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add minor fixes MasoniteFramework/masonite4
2 participants
@girardinsamuel @josephmancuso