-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running glide up
does not update glide.lock with latest revision of private repo
#327
Comments
I'm seeing similar behavior, just want to add that I'm seeing |
I have seen this error, and have worked around it by using |
@russmatney Are you setting the VCS fields ( |
@technosophos glide.yml is as such:
The errors/warnings are for |
I think @mattfarina may know why the VCS error is showing up. But the reason it's a stopping condition is that once a VCS can't be updated, we can't guarantee the consistency of the version tree anymore. Let me know if setting |
@russmatney Glide keeps compatibility with @technosophos should we keep |
@mattfarina sorry, why wouldn't we keep keep godep compat? the only reason i can imagine is because that means including the |
@sdboyer godep compat? Do you mean |
@mattfarina sorry, yes, butterfingers - |
@technosophos @mattfarina my mistake – I misread the errors and jumped to the wrong conclusion, namely that the private repo VCS errors were preventing the The private repo VCS warnings is a result of the state of gogs and go-import metadata: gogs/gogs#2825 I'm seeing proper |
@technosophos @mattfarina: We're seeing something that looks like this problem, but it doesn't happen for me, only for my colleagues. Here are the outputs of the exact same commands on my machine ( We're using the same version of Go and Glide. It's all on OS X. The only difference seems to be that my colleagues check out Git repos using the Setting |
I can reproduce it consistently now, but I'm not sure if it represent the original failure scenario exactly. First, I create this package: github.com/t11e/glidebug
import:
- package: github.com/aws/aws-sdk-go
version: 6f62fc3ff9aa98c629b350376825cda566658d75
subpackages:
- aws
- aws/awserr
- aws/session
- service/s3 Then I run Then I remove
Notice old version still remains. Still doesn't explain why it's otherwise working fine for me on my own repo and not my colleagues'. |
Great. After deleting my |
Here's another data point: $ cd vendor/github.com/aws/aws-sdk-go
$ cat .git/HEAD
6f62fc3ff9aa98c629b350376825cda566658d75
$ git status
HEAD detached at 6f62fc3
nothing to commit, working directory clean I see in git.go that if HEAD is detached, an update does nothing. Could this be the cause? |
@mattfarina Could this be related to #360? |
@technosophos @mattfarina: Can you spare some time to look at this? |
@atombender A couple quick questions...
|
@mattfarina: (1) Yes. (2) No. |
(You may have missed this since you're asking whether it has a |
Here's another data point: I find that I generally have to run $ grep -A1 glidetest glide.yaml
- name: github.com/t11e/glidetest
version: branch_x
$ (cd vendor/github.com/t11e/glidetest && git rev-parse HEAD)
399832009187ce47fde554d6d174b83ce58d13e2
$ grep -A1 glidetest glide.lock
- name: github.com/t11e/glidetest
version: 399832009187ce47fde554d6d174b83ce58d13e2 Now I edit $ grep -A1 glidetest glide.yaml
- name: github.com/t11e/glidetest
version: branch_y
$ glide up
[INFO] Downloading dependencies. Please wait...
[INFO] Fetching updates for github.com/t11e/glidetest.
[INFO] Setting version for github.com/t11e/glidetest to branch_y.
[...]
$ grep -A1 glidetest glide.lock
- name: github.com/t11e/glidetest
version: 399832009187ce47fde554d6d174b83ce58d13e2
$ (cd vendor/github.com/t11e/glidetest && git rev-parse HEAD)
399832009187ce47fde554d6d174b83ce58d13e2 Second try: $ glide up
[INFO] Downloading dependencies. Please wait...
[INFO] Fetching updates for github.com/t11e/glidetest.
[INFO] Setting version for github.com/t11e/glidetest to branch_y.
[...]
$ grep -A1 glidetest glide.lock
- name: github.com/t11e/glidetest
version: f28c1858bf5a4b0c4a23c33b09a97dc6cc6683bb Perhaps |
@mattfarina I have a working dir with the problem, where I can reproduce the problem consistently — ie., |
Never mind, I don't have a repo. But I may be able to create one. |
@mattfarina So can we expect anything to happen here? I can't imagine I'm the only one hit by this problem. |
@atombender i know it's not much solace for an immediate bug you're having now, but this will probably be resolved by the switch to the vsolver engine (i don't know exactly what's going on with this, so i can't be completely sure). that's progressing in #384, if you want to follow along. with any luck, it'll be at a point soon where you could test this issue against it, and see if it's still a problem. |
Anything new with this issue? Been 3 months and no progress. This is a serious bug. |
PING |
Are all of these issues still occurring with the 0.12 release? |
@sdboyer Yes, it is for me. |
@ryanwalls it seems quite strange to me that the dividing line here would be on private vs. public repos. I'm working through some related parts of the code now as part of #384 - maybe I'll run across something. |
👍 same here, having problems with glide.lock not updating to the glide.lock version. |
I have the same issue. I removed the repository inside ~/.glide/cache/src and rerun glide up, and noticed I now had the latest version. The code in ~/.glide/cache/src/<MY_REPO> was not getting updated to master. |
Same issue here. As noted by @cep21 , deleting repo from the cache helps. |
the original issue here is most likely a separate problem - if clearing the cache is solving your problems, then the fix we're working on for #592 should be what you need. |
I have a private repo that I have as a dependency of my project. When I push new code to the private repo and then run
glide up
in the project, the glide.lock file is not updated to the latest revision. I've worked around it by manually updating the lock file.Glide version: 0.9.1
Go version: 1.6
The text was updated successfully, but these errors were encountered: