Add machine-readable property definitions to repository #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
the
blocking-release
ml-evs
reviewed
Dec 22, 2022
vaitkus
reviewed
Dec 23, 2022
Co-authored-by: Antanas Vaitkus <[email protected]> Co-authored-by: Matthew Evans <[email protected]>
|
@ml-evs @vaitkus @oke464 @gmrigna @coreyoses @merkys @dwinston Thanks for all reviews and feedback. The PR is once again in a no-open-conversations state and needs to be re-approved. The most major thing corrected was the inconsistency of the "title" field, which is now hopefully consistently fixed. The rendered definitions at: https://schemas.optimade.org/releases/v1.2.0/ are refreshed with the current status. |
vaitkus
previously approved these changes
Mar 21, 2024
schemas/src/defs/v1.2/properties/optimade/common/chemical_symbol.yaml
Outdated
Show resolved
Hide resolved
merkys
previously approved these changes
Mar 21, 2024
ml-evs
previously approved these changes
Mar 21, 2024
Co-authored-by: Matthew Evans <[email protected]>
vaitkus
reviewed
Mar 21, 2024
schemas/src/defs/v1.2/properties/optimade/structures/space_group_symbol_hall.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Antanas Vaitkus <[email protected]>
oke464
approved these changes
Mar 21, 2024
vaitkus
approved these changes
Mar 21, 2024
ml-evs
approved these changes
Mar 21, 2024
merkys
approved these changes
Mar 22, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds machine-readable property definitions for all the OPTIMADE standardized properties using the format we developed over the last couple of workshops.
Old PR text:
This PR has started the work of adding property definitions to the repository on the format that is now in the specification.I've opened it as a pull request even though it is not yet finished to:- Make it more visible for discussions about the format.- To enable people to look things over while definitions are being added.- Possibly get help from others ("maintainers" should be able to push to the PR branch of my repo)Note: the referenced command: "make properties" is not yet in place.