-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define OPTIMADE regex format #490
Conversation
I'm not sure I see the need to couple the regexp format for search (e.g., a future |
We now have (at least) two different places in the specification for regex:es where we intend to standardize on subsets of PCRE2 so that not all implementations are forced to handle the full complexity of all of PCRE2 (or possibly worse, the specific ECMA-262 flavor of it, which may not even be 100% compatibly supported by the PCRE2 library in a few years). Does it not make sense to make these regex formats exactly the same? I suppose a property validator usually can be written with access to the full PCRE2 library. However, one may want to give a bit of consideration to the possibility of validating other data formats against these schemas - in which case it would be nice, e.g., if the |
Co-authored-by: Antanas Vaitkus <[email protected]>
@sauliusg You are the author of #160 for better string search in the filter language, which presently sits at us agreeing to skip "LIKE" and do a "MATCH" operator for a subset of PCRE2, with is what this appendix is trying to make precise. Can you please take a look at this quite short PR and say if you agree this is a useful appendix to standardize the right regex format for OPTIMADE filters? (The idea is that #160 can be updated to refer to this appendix once it has been merged). Note that I've left out range quantifiers ( |
Co-authored-by: Antanas Vaitkus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one formatting issue, otherwise good for me
Co-authored-by: Matthew Evans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Matthew Evans <[email protected]>
We keep coming back to the lack of regex:es in the OPTIMADE specification, in particular lately:
The challenges with picking one specific regex format has been debated quite intensely all the way back to, e.g., #42, for more recent discussions see far down in #160.
This PR creates a free-standing appendix that describes what I believe works as a regex format for OPTIMADE (see in particular the discussions far down in #160 to see the motivations for this particular format).
No parts of the specification itself yet refers to this appendix. This is intended to be added in #488 and #160.
It would be desirable to merge this fairly soon since it appears we have painted ourselves into a corner to a degree with regards to the need for the
pattern
JSON Schema validation field to properly validate the newspace_group_symmetry_operations_xyz
property.