Fixing a bug with calling delete on a single file as a string.

MaxCDN · Feb 27, 2014 · ada0d1a · ada0d1a
1 parent 90f93ad
commit ada0d1a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### v0.1.4
 
 - Adding alias for `maxcdn.del`.
+- Fixing a bug with calling delete on a single file as string.
 
 ### v0.1.3
 

diff --git a/README.md b/README.md
@@ -94,11 +94,6 @@ maxcdn.del('zones/pull.json/'+zoneId+'/cache', files, function(err, results) {
 });
 ```
 
-#### Not Implemented
-
-* post - fails with error, getting the same error with Ruby gem.
-
-
 ## Running Tests
 
 #### Unit Tests

diff --git a/index.js b/index.js
@@ -96,7 +96,7 @@ function del(url, files, callback) {
     }
 
     if (typeof files === 'string') {
-        files = "files="+string;
+        files = "files="+files;
     } else if (Array.isArray(files)) {
         files = stringify(files);
     } else if (files && files.files) {

diff --git a/test/index_test.js b/test/index_test.js
@@ -95,6 +95,15 @@ test('maxcdn', function(t) {
         t.notOk(data.arguments[3], 'delete sends data');
     });
 
+    m.delete('path', 'path1', function(err, data) {
+        t.error(err, 'delete (via Array) w/o error');
+        t.equal(data.foo, 'bar', 'delete (via Array) w/ data');
+        t.equal(data.arguments[0],
+                'https://rws.netdna.com/alias/path?files=path1',
+                'delete (via Array) w/ path');
+        t.notOk(data.arguments[3], 'delete (via Array) sends data');
+    });
+
     m.delete('path', ['path1','path2'], function(err, data) {
         t.error(err, 'delete (via Array) w/o error');
         t.equal(data.foo, 'bar', 'delete (via Array) w/ data');
@@ -120,6 +129,15 @@ test('maxcdn', function(t) {
         t.notOk(data.arguments[3], 'del sends data');
     });
 
+    m.del('path', 'path1', function(err, data) {
+        t.error(err, 'delete (via Array) w/o error');
+        t.equal(data.foo, 'bar', 'delete (via Array) w/ data');
+        t.equal(data.arguments[0],
+                'https://rws.netdna.com/alias/path?files=path1',
+                'delete (via Array) w/ path');
+        t.notOk(data.arguments[3], 'delete (via Array) sends data');
+    });
+
     m.del('path', ['path1','path2'], function(err, data) {
         t.error(err, 'del (via Array) w/o error');
         t.equal(data.foo, 'bar', 'del (via Array) w/ data');