From 024857f88223d18c1b6b878b5ec7867433fbf63b Mon Sep 17 00:00:00 2001 From: MaxRev Date: Mon, 11 Nov 2024 20:48:26 +0200 Subject: [PATCH 01/15] Disable warnings for hdf,proj,gdal --- osx/gdal-makefile | 11 +++++------ unix/gdal-makefile | 8 ++++---- win/partials.psm1 | 6 ++++-- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/osx/gdal-makefile b/osx/gdal-makefile index 407fd9c9e..9b83eba5f 100644 --- a/osx/gdal-makefile +++ b/osx/gdal-makefile @@ -99,8 +99,7 @@ configure_hdf: @cd $(HDF_CMAKE_TMP) && cmake $(HDF_SOURCE) \ -DCMAKE_INSTALL_PREFIX=$(BUILD_ROOT)/hdf-build -Wno-dev \ -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_C_FLAGS="-fPIC" \ - -DCMAKE_CXX_FLAGS="-fPIC" \ + -DCMAKE_C_FLAGS="-fPIC -w" \ -DCMAKE_PREFIX_PATH=$(VCPKG_INSTALLED_DYNAMIC) \ -DCMAKE_OSX_DEPLOYMENT_TARGET=$(OSX_DEPLOYMENT_TARGET) || exit 1 @@ -124,8 +123,8 @@ configure_gdal: @cd $(GDAL_CMAKE_TMP) && cmake $(GDAL_ROOT) \ -DCMAKE_INSTALL_PREFIX=$(BUILD_ROOT)/gdal-build -Wno-dev \ -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_C_FLAGS="-fPIC" \ - -DCMAKE_CXX_FLAGS="-fPIC" \ + -DCMAKE_C_FLAGS="-fPIC -w" \ + -DCMAKE_CXX_FLAGS="-fPIC -w" \ -DGDAL_USE_DEFLATE=OFF \ -DGDAL_USE_ZLIB_INTERNAL=ON \ -DGDAL_CSHARP_APPS=OFF \ @@ -164,8 +163,8 @@ configure_proj: cmake $(PROJ_ROOT) \ -DCMAKE_BUILD_TYPE=Release -Wno-dev \ -DCMAKE_MAKE_PROGRAM=make \ - -DCMAKE_C_FLAGS="-Wno-deprecated-declarations" \ - -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \ + -DCMAKE_C_FLAGS="-w" \ + -DCMAKE_CXX_FLAGS="-w" \ -DCMAKE_INSTALL_PREFIX=$(PROJ_BUILD) \ -DBUILD_TESTING=OFF \ -DBUILD_SHARED_LIBS=ON \ diff --git a/unix/gdal-makefile b/unix/gdal-makefile index 5ba499376..0d9db673d 100644 --- a/unix/gdal-makefile +++ b/unix/gdal-makefile @@ -115,8 +115,8 @@ configure_gdal: @cd $(GDAL_CMAKE_TMP) && cmake $(GDAL_ROOT) \ -DCMAKE_BUILD_TYPE=Release -Wno-dev \ - -DCMAKE_C_FLAGS="-fPIC" \ - -DCMAKE_CXX_FLAGS="-fPIC" \ + -DCMAKE_C_FLAGS="-fPIC -w" \ + -DCMAKE_CXX_FLAGS="-fPIC -w" \ -DGDAL_USE_DEFLATE=OFF \ -DGDAL_USE_ZLIB_INTERNAL=ON \ -DGDAL_CSHARP_APPS=ON \ @@ -145,8 +145,8 @@ configure_proj: cmake $(PROJ_ROOT) \ -DCMAKE_BUILD_TYPE=Release -Wno-dev\ -DCMAKE_MAKE_PROGRAM=make \ - -DCMAKE_C_FLAGS="-Wno-deprecated-declarations" \ - -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \ + -DCMAKE_C_FLAGS="-w" \ + -DCMAKE_CXX_FLAGS="-w" \ -DCMAKE_INSTALL_PREFIX=$(PROJ_BUILD) \ -DBUILD_TESTING=OFF \ -DBUILD_SHARED_LIBS=ON \ diff --git a/win/partials.psm1 b/win/partials.psm1 index a93f907a6..f0738f76c 100644 --- a/win/partials.psm1 +++ b/win/partials.psm1 @@ -152,6 +152,8 @@ function Install-Proj { cmake -G $env:VS_VERSION -A $env:CMAKE_ARCHITECTURE $env:PROJ_SOURCE ` -DCMAKE_INSTALL_PREFIX="$env:PROJ_INSTALL_DIR" ` -DCMAKE_BUILD_TYPE=Release -Wno-dev ` + -DCMAKE_C_FLAGS="/w" ` + -DCMAKE_CXX_FLAGS="/w" ` -DPROJ_TESTS=OFF -DBUILD_LIBPROJ_SHARED=ON ` -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_ROOT\scripts\buildsystems\vcpkg.cmake" ` -DCMAKE_PREFIX_PATH="$env:VCPKG_ROOT\installed\x64-windows;$env:SDK_PREFIX" ` @@ -251,7 +253,7 @@ function Build-Gdal { New-FolderIfNotExistsAndSetCurrentLocation $env:GdalCmakeBuild New-FolderIfNotExists "$PSScriptRoot\..\nuget" - $env:ARCH_FLAGS = "/arch:AVX2 /Ob2 /Oi /Os /Oy" + $env:ARCH_FLAGS = "/arch:AVX2 /Ob2 /Oi /Os /Oy /w" $env:VCPKG_INSTALLED = "$env:BUILD_ROOT\vcpkg\installed\x64-windows" # disabling KEA driver as it causes build issues on Windows # https://github.com/OSGeo/gdal/blob/3b232ee17d8f3d93bf3535b77fbb436cb9a9c2e0/.github/workflows/windows_build.yml#L178 @@ -265,9 +267,9 @@ function Build-Gdal { cmake -G $env:VS_VERSION -A $env:CMAKE_ARCHITECTURE "$env:GDAL_SOURCE" ` $env:CMAKE_INSTALL_PREFIX -DCMAKE_BUILD_TYPE=Release -Wno-dev ` -DCMAKE_C_FLAGS="$env:ARCH_FLAGS" ` + -DCMAKE_CXX_FLAGS="$env:ARCH_FLAGS" ` -DCMAKE_PREFIX_PATH="$env:VCPKG_INSTALLED;$env:SDK_PREFIX" ` -DGDAL_USE_OPENEXR=OFF ` - -DCMAKE_CXX_FLAGS="$env:ARCH_FLAGS" ` $env:WEBP_INCLUDE $env:WEBP_LIB ` $env:PROJ_ROOT $env:MYSQL_LIBRARY ` $env:POPPLER_EXTRA_LIBRARIES ` From 77a39344c8e245c82988136d5025f93a17ff06c8 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Mon, 11 Nov 2024 20:48:49 +0200 Subject: [PATCH 02/15] Bump package versions in tests --- .../MaxRev.Gdal.Core.Tests.AzureFunctions.csproj | 2 +- .../MaxRev.Gdal.Core.Tests.XUnit.csproj | 2 +- tests/MaxRev.Gdal.Core.Tests/MaxRev.Gdal.Core.Tests.csproj | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/MaxRev.Gdal.Core.Tests.AzureFunctions/MaxRev.Gdal.Core.Tests.AzureFunctions.csproj b/tests/MaxRev.Gdal.Core.Tests.AzureFunctions/MaxRev.Gdal.Core.Tests.AzureFunctions.csproj index 06bd57e0a..634ccf591 100644 --- a/tests/MaxRev.Gdal.Core.Tests.AzureFunctions/MaxRev.Gdal.Core.Tests.AzureFunctions.csproj +++ b/tests/MaxRev.Gdal.Core.Tests.AzureFunctions/MaxRev.Gdal.Core.Tests.AzureFunctions.csproj @@ -7,7 +7,7 @@ <_FunctionsSkipCleanOutput>true - + diff --git a/tests/MaxRev.Gdal.Core.Tests.XUnit/MaxRev.Gdal.Core.Tests.XUnit.csproj b/tests/MaxRev.Gdal.Core.Tests.XUnit/MaxRev.Gdal.Core.Tests.XUnit.csproj index 43be02e82..6fc593e05 100644 --- a/tests/MaxRev.Gdal.Core.Tests.XUnit/MaxRev.Gdal.Core.Tests.XUnit.csproj +++ b/tests/MaxRev.Gdal.Core.Tests.XUnit/MaxRev.Gdal.Core.Tests.XUnit.csproj @@ -7,7 +7,7 @@ x64;arm64 - + diff --git a/tests/MaxRev.Gdal.Core.Tests/MaxRev.Gdal.Core.Tests.csproj b/tests/MaxRev.Gdal.Core.Tests/MaxRev.Gdal.Core.Tests.csproj index 7e89cf288..45be806c3 100644 --- a/tests/MaxRev.Gdal.Core.Tests/MaxRev.Gdal.Core.Tests.csproj +++ b/tests/MaxRev.Gdal.Core.Tests/MaxRev.Gdal.Core.Tests.csproj @@ -8,7 +8,7 @@ MaxRev.Gdal.Core.Tests - + \ No newline at end of file From 6c71b726f41481f2fec18a80058eb37244c0014b Mon Sep 17 00:00:00 2001 From: MaxRev Date: Mon, 11 Nov 2024 20:55:19 +0200 Subject: [PATCH 03/15] Drop proj-datum (deprecated) --- win/install.ps1 | 2 -- win/partials.psm1 | 16 ---------------- 2 files changed, 18 deletions(-) diff --git a/win/install.ps1 b/win/install.ps1 index cb8f500a0..7530df708 100644 --- a/win/install.ps1 +++ b/win/install.ps1 @@ -47,8 +47,6 @@ try { Install-Proj -cleanProjBuild $cleanProjBuild -cleanProjIntermediate $cleanProjIntermediate - Get-ProjDatum - Reset-GdalSourceBindings $env:INCLUDE = Add-EnvVar $env:INCLUDE "$env:SDK_PREFIX\include" $env:LIB = Add-EnvVar $env:LIB "$env:SDK_PREFIX\lib" diff --git a/win/partials.psm1 b/win/partials.psm1 index f0738f76c..4a34228b9 100644 --- a/win/partials.psm1 +++ b/win/partials.psm1 @@ -2,8 +2,6 @@ function Set-GdalVariables { $env:VS_VERSION = "Visual Studio 17 2022" $env:SDK = "release-1930-x64" #2022 x64 $env:SDK_ZIP = "$env:SDK" + "-dev.zip" - $env:PROJ_DATUM = "proj-datumgrid-1.8.zip" - $env:PROJ_DATUM_URL = "http://download.osgeo.org/proj/$env:PROJ_DATUM" $env:SDK_URL = "http://download.gisinternals.com/sdk/downloads/$env:SDK_ZIP" $env:LIBWEBP_URL = "https://storage.googleapis.com/downloads.webmproject.org/releases/webp/libwebp-1.3.2-windows-x64.zip" $env:LIBZSTD_URL = "https://github.com/facebook/zstd/releases/download/v1.5.5/zstd-v1.5.5-win64.zip" @@ -11,7 +9,6 @@ function Set-GdalVariables { $env:VS_VER = "2022" $env:ARCHITECTURE = "amd64" $env:WIN64_ARG = "WIN64=YES" - $env:platform = "x64" $env:CMAKE_ARCHITECTURE = "x64" $env:CMAKE_PARALLEL_JOBS = 4 @@ -163,19 +160,6 @@ function Install-Proj { Write-BuildStep "Done building PROJ" } -function Get-ProjDatum { - Write-BuildStep "Checking for PROJ datum grid" - Set-Location "$env:BUILD_ROOT\proj-build\share\proj" - if (-Not (Test-Path -Path $env:PROJ_DATUM -PathType Leaf)) { - Write-BuildInfo "Downloading PROJ datum grid" - Invoke-WebRequest $env:PROJ_DATUM_URL -OutFile $env:PROJ_DATUM - Write-BuildStep "PROJ datum grid was downloaded" - } - else { - Write-BuildStep "PROJ datum grid already exists" - } -} - function Get-GdalVersion { return (Get-Content "$env:GDAL_SOURCE\VERSION") } From 9c73c768105771c7cd6d45d1dea50054cae0c9c3 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Mon, 11 Nov 2024 20:57:46 +0200 Subject: [PATCH 04/15] Consolidate variables on windows --- win/partials.psm1 | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/win/partials.psm1 b/win/partials.psm1 index 4a34228b9..64579dcaf 100644 --- a/win/partials.psm1 +++ b/win/partials.psm1 @@ -23,11 +23,11 @@ function Set-GdalVariables { $env:GDAL_DRIVER_PATH = "$env:GDAL_INSTALL_DIR\share\gdal" $env:PROJ_LIB = "$env:PROJ_INSTALL_DIR\share\proj" $env:GdalCmakeBuild = "$env:BUILD_ROOT\gdal-cmake-temp" - $env:VCPKG_INSTALLED_PKGCONFIG = "$env:BUILD_ROOT\vcpkg\installed\x64-windows\lib\pkgconfig" $env:SDK_LIB = "$env:SDK_PREFIX\lib" $env:SDK_BIN = "$env:SDK_PREFIX\bin" $env:GDAL_INSTALL_DIR = "$env:BUILD_ROOT\gdal-build" $env:VCPKG_INSTALLED = "$env:BUILD_ROOT\vcpkg\installed\x64-windows" + $env:VCPKG_INSTALLED_PKGCONFIG = "$env:VCPKG_INSTALLED\lib\pkgconfig" $env:WEBP_ROOT = Get-ForceResolvePath("$env:BUILD_ROOT\sdk\libwebp*") } @@ -153,7 +153,7 @@ function Install-Proj { -DCMAKE_CXX_FLAGS="/w" ` -DPROJ_TESTS=OFF -DBUILD_LIBPROJ_SHARED=ON ` -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_ROOT\scripts\buildsystems\vcpkg.cmake" ` - -DCMAKE_PREFIX_PATH="$env:VCPKG_ROOT\installed\x64-windows;$env:SDK_PREFIX" ` + -DCMAKE_PREFIX_PATH="$env:VCPKG_INSTALLED;$env:SDK_PREFIX" ` -DBUILD_SHARED_LIBS=ON -DENABLE_CURL=ON -DENABLE_TIFF=ON exec { cmake --build . -j $env:CMAKE_PARALLEL_JOBS --config Release --target install } @@ -238,7 +238,6 @@ function Build-Gdal { New-FolderIfNotExists "$PSScriptRoot\..\nuget" $env:ARCH_FLAGS = "/arch:AVX2 /Ob2 /Oi /Os /Oy /w" - $env:VCPKG_INSTALLED = "$env:BUILD_ROOT\vcpkg\installed\x64-windows" # disabling KEA driver as it causes build issues on Windows # https://github.com/OSGeo/gdal/blob/3b232ee17d8f3d93bf3535b77fbb436cb9a9c2e0/.github/workflows/windows_build.yml#L178 From d3b7e0207fbfd792c7bb563f8e2e84a247a4d2c3 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:24:20 +0200 Subject: [PATCH 05/15] Updating workflows with optional jobs for targets [no osx] [no unix] --- .github/workflows/macos.yml | 4 ++++ .github/workflows/main.yml | 13 +++++++++++++ .github/workflows/unix.yml | 4 ++++ .github/workflows/windows.yml | 4 ++++ 4 files changed, 25 insertions(+) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 23283250a..93e70bb44 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -12,6 +12,9 @@ on: is-version-branch: type: boolean required: true + skip: + type: boolean + required: true env: DOTNET_INSTALL_DIR: ${{ github.workspace }}/.dotnet/ @@ -19,6 +22,7 @@ env: jobs: BuildNugetPackages-MacOS: + if: ${{ ! inputs.skip }} strategy: matrix: os: [macos-14, macos-13] diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f63d57523..79c139d7f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -26,6 +26,9 @@ jobs: is-pre-release: ${{ steps.set.outputs.is_pre_release }} dotnet-version: ${{ steps.set.outputs.dotnet_version }} is-version-branch: ${{ steps.set.outputs.is_version_branch }} + skip-unix: ${{ steps.set.outputs.skip_unix }} + skip-windows: ${{ steps.set.outputs.skip_windows }} + skip-osx: ${{ steps.set.outputs.skip_osx }} steps: - name: Set env for the reusable workflows id: set @@ -37,6 +40,13 @@ jobs: else echo "is_version_branch=false" >> $GITHUB_OUTPUT fi + for os in unix windows osx; do + if git log -1 --format=%B ${{ github.sha }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then + echo "skip_$os=true" >> $GITHUB_OUTPUT + else + echo "skip_$os=false" >> $GITHUB_OUTPUT + fi + done LinuxBuild: needs: env-context @@ -46,6 +56,7 @@ jobs: is-pre-release: ${{ fromJSON(needs.env-context.outputs.is-pre-release) }} dotnet-version: ${{ needs.env-context.outputs.dotnet-version }} is-version-branch: ${{ fromJSON(needs.env-context.outputs.is-version-branch) }} + skip: ${{ fromJSON(needs.env-context.outputs.skip-unix) }} WindowsBuild: needs: env-context @@ -55,6 +66,7 @@ jobs: is-pre-release: ${{ fromJSON(needs.env-context.outputs.is-pre-release) }} dotnet-version: ${{ needs.env-context.outputs.dotnet-version }} is-version-branch: ${{ fromJSON(needs.env-context.outputs.is-version-branch) }} + skip: ${{ fromJSON(needs.env-context.outputs.skip-windows) }} MacOSBuild: needs: env-context @@ -64,6 +76,7 @@ jobs: is-pre-release: ${{ fromJSON(needs.env-context.outputs.is-pre-release) }} dotnet-version: ${{ needs.env-context.outputs.dotnet-version }} is-version-branch: ${{ fromJSON(needs.env-context.outputs.is-version-branch) }} + skip: ${{ fromJSON(needs.env-context.outputs.skip-osx) }} TestAndPushPackages: needs: [env-context, LinuxBuild, WindowsBuild, MacOSBuild] diff --git a/.github/workflows/unix.yml b/.github/workflows/unix.yml index d30f3b167..19f58d79f 100644 --- a/.github/workflows/unix.yml +++ b/.github/workflows/unix.yml @@ -12,6 +12,9 @@ on: is-version-branch: type: boolean required: true + skip: + type: boolean + required: true env: DOCKER_REGISTRY: ghcr.io/maxrev-dev @@ -22,6 +25,7 @@ permissions: jobs: BuildNugetPackages-Linux: + if: ${{ ! inputs.skip }} strategy: matrix: include: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index b0026c50b..d003e65b5 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -12,6 +12,9 @@ on: is-version-branch: type: boolean required: true + skip: + type: boolean + required: true env: DOTNET_INSTALL_DIR: ${{ github.workspace }}/.dotnet @@ -19,6 +22,7 @@ env: jobs: BuildNugetPackages-Windows: + if: ${{ ! inputs.skip }} strategy: matrix: os: [windows-latest] From d04f595cdf3a31141fa4a11c428eb93d411a0317 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:28:41 +0200 Subject: [PATCH 06/15] Add git checkout [no osx] [no unix] --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 79c139d7f..004149f8b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,6 +30,8 @@ jobs: skip-windows: ${{ steps.set.outputs.skip_windows }} skip-osx: ${{ steps.set.outputs.skip_osx }} steps: + - name: Checkout repository + uses: actions/checkout@v4 - name: Set env for the reusable workflows id: set run: | From c26144de0856cac7c9eb524323b9c96224e0a370 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:31:50 +0200 Subject: [PATCH 07/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 004149f8b..88a348c23 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -42,13 +42,13 @@ jobs: else echo "is_version_branch=false" >> $GITHUB_OUTPUT fi - for os in unix windows osx; do + for os in unix windows osx; do if git log -1 --format=%B ${{ github.sha }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT else echo "skip_$os=false" >> $GITHUB_OUTPUT fi - done + done LinuxBuild: needs: env-context From cdf1d5a8e64083cfe8c0811ce86f639206d4670e Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:36:25 +0200 Subject: [PATCH 08/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 88a348c23..019959040 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -32,6 +32,9 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Set env for the reusable workflows id: set run: | From 4a8a6ab628ea4154035dc832d49e798098e92e65 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:43:36 +0200 Subject: [PATCH 09/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 019959040..7e86ba24a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -45,6 +45,7 @@ jobs: else echo "is_version_branch=false" >> $GITHUB_OUTPUT fi + # Skip build for specific OS for os in unix windows osx; do if git log -1 --format=%B ${{ github.sha }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT From 188372638d9f4c59843fa8b070caf3288814daa4 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:47:57 +0200 Subject: [PATCH 10/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7e86ba24a..0f590bbf8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -47,7 +47,7 @@ jobs: fi # Skip build for specific OS for os in unix windows osx; do - if git log -1 --format=%B ${{ github.sha }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then + if git log -1 --format=%B ${{ github.event.head_commit.message }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT else echo "skip_$os=false" >> $GITHUB_OUTPUT From 2287f9261f16deb153df067171825c9f7aad16b6 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:52:15 +0200 Subject: [PATCH 11/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0f590bbf8..517ae9035 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -47,7 +47,7 @@ jobs: fi # Skip build for specific OS for os in unix windows osx; do - if git log -1 --format=%B ${{ github.event.head_commit.message }} | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then + if git log -1 --pretty=format:"%s" | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT else echo "skip_$os=false" >> $GITHUB_OUTPUT From b8dd5789570343e6b3d9f826452542d420c9175f Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:55:14 +0200 Subject: [PATCH 12/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 517ae9035..3a60df38c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -47,7 +47,7 @@ jobs: fi # Skip build for specific OS for os in unix windows osx; do - if git log -1 --pretty=format:"%s" | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then + if git log -1 --pretty=format:"%B" | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT else echo "skip_$os=false" >> $GITHUB_OUTPUT From c64cb95b0708246c4c9f95380fe47234bfc70e4b Mon Sep 17 00:00:00 2001 From: MaxRev Date: Wed, 13 Nov 2024 23:58:37 +0200 Subject: [PATCH 13/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3a60df38c..a1e21f4ed 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -38,13 +38,13 @@ jobs: - name: Set env for the reusable workflows id: set run: | - echo "is_pre_release=$IS_PRE_RELEASE" >> $GITHUB_OUTPUT + echo "is_pre_release=$IS_PRE_RELEASE" >> $GITHUB_OUTPUT echo "dotnet_version=$DOTNET_VERSION" >> $GITHUB_OUTPUT if [[ ${{ github.ref }} =~ ^refs/heads/v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo "is_version_branch=true" >> $GITHUB_OUTPUT else echo "is_version_branch=false" >> $GITHUB_OUTPUT - fi + fi; # Skip build for specific OS for os in unix windows osx; do if git log -1 --pretty=format:"%B" | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then From 641fc68dee4e32610219404b03ab2f3689313694 Mon Sep 17 00:00:00 2001 From: MaxRev Date: Thu, 14 Nov 2024 00:02:36 +0200 Subject: [PATCH 14/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a1e21f4ed..859dcea5f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -46,11 +46,14 @@ jobs: echo "is_version_branch=false" >> $GITHUB_OUTPUT fi; # Skip build for specific OS + git log -1 --pretty=format:"%B" | cat for os in unix windows osx; do if git log -1 --pretty=format:"%B" | grep -Eq "\[(skip|no) $os\]|\[$os skip\]"; then echo "skip_$os=true" >> $GITHUB_OUTPUT + echo "Skip build for $os" else echo "skip_$os=false" >> $GITHUB_OUTPUT + echo "Building for $os" fi done From 4bb49839974d1d56ec95112c826bda1643b0179f Mon Sep 17 00:00:00 2001 From: MaxRev Date: Thu, 14 Nov 2024 00:14:43 +0200 Subject: [PATCH 15/15] Update workflow [no osx] [no unix] --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 859dcea5f..b4d5715df 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -33,7 +33,7 @@ jobs: - name: Checkout repository uses: actions/checkout@v4 with: - fetch-depth: 0 + ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} - name: Set env for the reusable workflows id: set