-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the realtime page to open issue tabs in iframes #15
Comments
Also, we could preserve urls per tab using session storage: But we could also use mithril.js with this module: However, I realized we cannot implement this yet. If a user is on another tab when a call is answered, the realtime browser tab would add an iframe html tab but the focus would not be set to the realtime tab. So till we solve this, we could not use this approach. Unless we are satisfied in just adding some indication that the realtime tab was updated. (but maybe we can find a way for the tab to set focus to itself). |
But this might be enough: |
"Agile Web Development with Rails 6" says: |
The realtime page should popup issues in iframes inside tabs.
It should store/restore tabs using local storage.
The tabs should contain 'close' icon to permit to close them.
Also, we should pass a parameter bare=true in the querystring url of the issue so that we can ask redmine to not include the headers (menus) in the retrieved page and any other things like sidebar.
Maybe there are some hints here: https://www.redmine.org/boards/1/topics/59964
We probably should use deface gem :remove via redmine_base_deface:
https://github.com/spree/deface
But if it gets complicated, javascript in the page could remove the header/sidebar.
For better effect we might need to make the tab content invisible till the iframe javascript informs it removed the header/sidebar (using BroadcastChannel)
Also, if bare=true gets complicated to process (in particular, in case of edition/submit of the issue), we the javascript client code can detect if it running in an iframe:
https://www.geeksforgeeks.org/how-to-check-a-webpage-is-loaded-inside-an-iframe-or-into-the-browser-window-using-javascript/
The text was updated successfully, but these errors were encountered: