Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failure to update under some cases #58

Conversation

sk-ys
Copy link
Contributor

@sk-ys sk-ys commented Feb 18, 2024

Related to #53 and #55, I found that in some cases the update failed when following plugins were used.

  • redmineup, redmine_checklists plugin
  • redmineup, redmineup_tags plugin

Therefore, I temporarily reviewed the process of updating issue attributes.
However, the aforementioned plugins are not compatible completely.

@MayamaTakeshi
Copy link
Owner

I did a quick test. I have only plugin redmine_rt installed and I noticed the last changes inserted a regression and the 'related issues' are not updated in real time anymore.

@sk-ys sk-ys force-pushed the address-failure-to-update-under-some-cases branch from 22a95c8 to 1843de5 Compare February 18, 2024 11:49
@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 18, 2024

I'm sorry, I commited to a branch that is not the latest.
I'm forcing update on the same branch. Please check again.

@MayamaTakeshi MayamaTakeshi merged commit 1843de5 into MayamaTakeshi:master Feb 21, 2024
1 check passed
@MayamaTakeshi
Copy link
Owner

OK. I tested with only my plugin installed and since there was no impact I merged your changes (since I am not using redmine_checklists/redmine_tags, I am not checking for conflicts with them).

@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 21, 2024

Thank you so much.

@sk-ys sk-ys deleted the address-failure-to-update-under-some-cases branch February 25, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants