admin create notification page and route #160
Conversation
emmaeagles
force-pushed
the
emma/admin-notif
branch
from
8ecccbd to
32a755a
Compare
|
Can you align the "Send Notifications to Selected Students" button to the left instead of the middle? |
|
|
| }, | ||
| methods: { | ||
| goToStudentCoop() { | ||
| this.$router.push("/admin/studentcoops"); |
There was a problem hiding this comment.
nit: change this route to /admin/student-coops
There was a problem hiding this comment.
this isnt even a real page but ok lol
| @click="sendNotification()" | ||
| label="Send Notification" | ||
| class="notifPageComponents" | ||
| /> |
There was a problem hiding this comment.
Add a q-spinner here that should show while the notifications are being created (just better for UX, it's been done in a bunch of other pages/components already)
|
|
||
| <style scoped lang="scss"> | ||
| h6 { | ||
| margin: 10px; |
There was a problem hiding this comment.
You can use the q-ma-md class instead of defining the styles yourself (ma = margin-all, md= medium). https://quasar.dev/style/spacing#Examples
There was a problem hiding this comment.
this literally never ends up working the way i want it to so i really dont want to waste more time trying to get this shit to align properly so i dont rlly want to go down this road again
There was a problem hiding this comment.
Ok no worries it's not a big deal
| /> | ||
| <q-btn | ||
| v-if="!sending" | ||
| color="primary" |
There was a problem hiding this comment.
Add :disabled="sending" here to disable the button while it's sending
There was a problem hiding this comment.
it doesnt show up when its sending tho
|
|
||
| <style scoped lang="scss"> | ||
| h6 { | ||
| margin: 10px; |
There was a problem hiding this comment.
Ok no worries it's not a big deal
Summary
From the student list page, the admin can filter students to select who they want to send a notification to by choosing students then clicking the button below the table.
This brings them to a page where they can modify the list of students and write a title and body for the notification.
Test Plan
How did you test your changes?
screenshots are attached
Related Issues
Which issues does this PR resolve/work on?
#104