add CMake build system support #240
Conversation
There was a problem hiding this comment.
Thanks for this - this should actually be the default way to build Qt at least for Qt6.
It would also make sense to add workflows in the CI to build the latest Qt5 and Qt6 version, to be able to test this - for the time being probably parallel to the existing workflows using qmake.
CMakeLists.txt
Outdated
| endif() | ||
| # elseif(${QT_VERSION_MAJOR} VERSION_EQUAL 6) | ||
| else() | ||
| message(FATAL "No generated sources exist for Qt${QT_VERSION}") |
There was a problem hiding this comment.
This does not handle the (actually preferred) case of self-generated wrappers in generated_cpp, as done in the qmake file. Especially this will not work for Qt6, unless I'm missing something.
There was a problem hiding this comment.
I'm trying to build generator using CMake, and so far it's testing well.
|
|
||
| target_compile_definitions(${PROJECT_NAME} PRIVATE PYTHONQT_QTALL_EXPORTS) | ||
|
|
||
| list(APPEND QTMODULES Core Gui Svg Sql Network OpenGL Xml XmlPatterns Multimedia Qml Quick UiTools WebEngineWidgets WebKit) |
There was a problem hiding this comment.
I think this list shall be different for Qt5 and Qt6.
There was a problem hiding this comment.
I think as long as there are no modules with the same name but different functionality in Qt 5 and Qt 6, there shouldn't be a problem.
|
@jcfr This may be a PR of interest to you based on your previous work from 2019 to CMake’ify PythonQt as completed in https://github.com/commontk/PythonQt/blob/patched-9/CMakeLists.txt (though currently for Qt5 PythonQt only). |
No description provided.