Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Choreo trajectories #269

Open
spacey-sooty opened this issue Nov 13, 2024 · 2 comments · May be fixed by #271
Open

Add support for Choreo trajectories #269

spacey-sooty opened this issue Nov 13, 2024 · 2 comments · May be fixed by #271
Labels
enhancement New feature or request

Comments

@spacey-sooty
Copy link

Is your feature request related to a problem? Please describe.
I have my Choreo trajectories in code and would like to be able to display them on the odometry view so I can view my robots tracking of them. The samples implement struct serialisable and store a pose2d but advantagescope wont use that properly to display them.

Describe the solution you'd like
I'd like to be able to display my trajectories using an array of samples. It would be nice to be able to display this as both a line and the robot at each point.

Describe alternatives you've considered
I can just log it as a Pose2d

Additional context
Something similar is probably possible for pathplanner

@spacey-sooty spacey-sooty added the enhancement New feature or request label Nov 13, 2024
@jwbonner
Copy link
Member

PathPlanner's telemetry already logs an array of poses, which AdvantageScope can visualize. What is the format of the Choreo trajectories?

@spacey-sooty
Copy link
Author

PathPlanner's telemetry already logs an array of poses, which AdvantageScope can visualize. What is the format of the Choreo trajectories?

Choreo trajectories are essentially a struct array with either SwerveSamples or DifferentialSamples. You can see the corresponding struct definition in each file. This would just need to pull out the Pose2d structs from the entry and use those

@jwbonner jwbonner changed the title Allow overlaying a trajectory to odometry or 3d field view Add support for Choreo trajectories Nov 14, 2024
@spacey-sooty spacey-sooty linked a pull request Nov 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants