Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2D poses with game piece objects #276

Open
blaze-developer opened this issue Nov 25, 2024 · 1 comment
Open

Add support for 2D poses with game piece objects #276

blaze-developer opened this issue Nov 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@blaze-developer
Copy link

I am localizing note positions in a 2D space. I noticed that when logging a note using a Pose2d, the note's origin is the very center of the note. However, if someone is only logging a 2D pose, would it be safe to assume that the note is lying on the ground and not inside the ground? Adding an offset would make user code more readable by simply not having to add an offset to every logged value.

image

@blaze-developer blaze-developer added the enhancement New feature or request label Nov 25, 2024
@jwbonner
Copy link
Member

To be clear, AdvantageScope doesn't currently support visualizing game piece objects using 2D poses (only 3D poses, transforms, and translations). If we added support for displaying game pieces using 2D poses, I agree that this would be a sensible way to do it.

@jwbonner jwbonner changed the title Assume 2d note positions are laying on the ground Add support for 2D poses with game piece objects Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants