Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Component Poses ignore base robot model transformations. #279

Open
blaze-developer opened this issue Nov 25, 2024 · 2 comments
Open

3D Component Poses ignore base robot model transformations. #279

blaze-developer opened this issue Nov 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@blaze-developer
Copy link

blaze-developer commented Nov 25, 2024

In our robot's model, we have to transform the robot model up for the wheels to be above the ground. However, when logging component poses, it does not respect this offset. This means we have to add an arbitrary offset to every single component pose. It would be nice to either make it respect these transformations or allow JSON configuration of these components to respect or not respect these.

image

@blaze-developer blaze-developer added the bug Something isn't working label Nov 25, 2024
@jwbonner
Copy link
Member

Component poses are always relative to the robot origin, which is defined to be on the ground. This is the standard reference frame used for everything in AdvantageScope. When following the documented setup steps, component poses can be published using that same reference frame. I'm not sure I understand what the issue is. Are you trying to use a different reference frame for publishing components?

@blaze-developer
Copy link
Author

blaze-developer commented Nov 25, 2024

image

This is my configuration. I am using a 0.045 meter z offset to get the wheels onto the ground.

image

My problem, is that the visualized component poses are relative to the floor, and not the offset robot pose, the components do not follow the robot with its transformations.

image

The result of this, being I have to add 0.045 to the z factor of every single component, to make them fit, like so:

image

Wouldnt it make sense for the components to be relative to the actual origin of the robot model, instead of the floor always?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants