Merge pull request #23 from Medium/giannic-ios-enum

add TitleCase to enum names to support iOS enum conventions
Medium · Jul 20, 2015 · 1bfbd7e · 1bfbd7e
2 parents b252a15 + 3e3c84c
commit 1bfbd7e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/lib/descriptors/EnumDescriptor.js b/lib/descriptors/EnumDescriptor.js
@@ -5,6 +5,7 @@
 
 var util = require('util')
 var Descriptor = require('./Descriptor')
+var helper = require('../helper')
 
 /**
  * @param {string} name Name of the enumeration
@@ -63,7 +64,11 @@ EnumDescriptor.prototype.getNames = function () {
 
 EnumDescriptor.prototype.getValueForNumber = function (number) {
   var name = this._names[number]
-  return name ? { name: name, number: number } : null
+  return name ? {
+    name: name,
+    titleName: helper.toTitleCase(name),
+    number: number
+  } : null
 }
 
 

diff --git a/lib/helper.js b/lib/helper.js
@@ -57,7 +57,8 @@ exports.extend = function (var_args) {
  * @return {string}
  */
 exports.toCamelCase = function(str) {
-  return String(str).replace(/\_([a-z])/g, function(all, match) {
+  var lowerCase = str.toLowerCase()
+  return String(lowerCase).replace(/\_([a-z])/g, function(all, match) {
     return match.toUpperCase()
   })
 }

diff --git a/tests/project_test.js b/tests/project_test.js
@@ -30,9 +30,10 @@ exports.testGetProtos = function (test) {
   var enums = personProtos[0].toTemplateObject().messages[0].enums
   test.equal(1, enums && enums.length)
   test.deepEqual(
-    {name: 'PhoneType', values: [{name: 'MOBILE', number: 0},
-                                 {name: 'HOME', number: 1},
-                                 {name: 'WORK', number: 2}]},
+    {name: 'PhoneType', values: [{name: 'MOBILE', titleName: 'Mobile', number: 0},
+                                 {name: 'HOME', titleName: 'Home', number: 1},
+                                 {name: 'WORK', titleName: 'Work', number: 2},
+                                 {name: 'WORK_FAX', titleName: 'WorkFax', number: 3}]},
     enums[0])
 
   test.done()

diff --git a/tests/protos/person.proto b/tests/protos/person.proto
@@ -21,6 +21,7 @@ message Person {
     // Comment
     HOME = 1;
     WORK = 2;
+    WORK_FAX = 3;
   }
 
   message PhoneNumber {