-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson build system #256
Draft
andy5995
wants to merge
62
commits into
MegaGlest:develop
Choose a base branch
from
zetaglest:meson
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91ac06d
to
1864bac
Compare
andy5995
commented
Aug 25, 2022
source/shared_lib/meson.build
Outdated
dep_fribidi = dependency('fribidi') | ||
dep_glib = dependency('glib-2.0') | ||
|
||
inc_ircclient = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked about (reported) this in mesonbuild/meson#10738
Too bad I forgot to specifically ask if there was a better way to write this condition for libircclient. Maybe I'll do that later.
284b3c3
to
c4b0c4c
Compare
2f7d903
to
3396bd2
Compare
d7ea283
to
a9c57e6
Compare
ebc66f8
to
6696aae
Compare
Although probably better to find what's causing the problem, rather than undefining the macro https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html _GLIBCXX_ASSERTIONS Defined by default when compiling with no optimization, undefined by default when compiling with optimization. When defined, enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers.
This is related to 9b97dd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding @mesonbuild
Something me and @Jammyjamjamman started
This is in the early stages and not even half-done yet.
After completion, this will probably live alongside cmake for a while. I expect the MG maintainers would want to at least wait until after the next release before considering the removal of the CMake stuff.