Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Some placed book models are broken #1270

Closed
5 tasks done
FreyrDev opened this issue Dec 6, 2024 · 5 comments
Closed
5 tasks done

[🐞]: Some placed book models are broken #1270

FreyrDev opened this issue Dec 6, 2024 · 5 comments
Labels
1.21.1 Minecraft Version bug Something isn't working

Comments

@FreyrDev
Copy link

FreyrDev commented Dec 6, 2024

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.21.1-FABRIC

Supplementaries Version

supplementaries-1.21-3.0.25-beta-fabric

Moonlight Lib Version

moonlight-1.21-2.17.10-fabric

Describe Issue

Some colours of placed books appear to use a different texture layout and thus don't have the correct UVs. Some book textures were updated in 93b7ec2 and 40ed094 but not all.

Placed enchanted books also seem to be using any book texture at random rather than exclusively the enchanted one, which I assume is a bug.

2024-12-06_01 35 41

@FreyrDev FreyrDev added the bug Something isn't working label Dec 6, 2024
@github-actions github-actions bot added the 1.21.1 Minecraft Version label Dec 6, 2024
@Partonetrain
Copy link

Book Piles are invisible for me on NeoForge, but this might not be related

@maloryware
Copy link

Issue replicated on 1.21 Fabric. No info on logs.
Are you using a modpack? If so, could you share a list of mods?

@stlouisn
Copy link

not sure if its related to this issue but if not, close enough. book_piles are invisible. there are no errors, no logs required.

tested on fabric 1.21.1 loader 0.16.9 with only moonlight 1.21-2.17.12, amendments 1.21-1.2.19, and supplementaries 1.21-3.0.28-beta

suspect its related to file:

https://github.com/MehVahdJukaar/Supplementaries/blob/1.21/common/src/main/resources/assets/supplementaries/models/block/book_pile.json

2024-12-22_14 19 09

@maloryware
Copy link

Same thing - confirm that now the models disappear entirely. Not sure what changed on our side, either.

@MehVahdJukaar
Copy link
Owner

not really fixed but book piles have been properly disabled until they are ready to be added again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants