Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after hitting an entity with a torch (incompatibility between soul fire'd & amendments) #142

Closed
Kloytz opened this issue Oct 13, 2024 · 4 comments

Comments

@Kloytz
Copy link

Kloytz commented Oct 13, 2024

message.txt

@Kloytz
Copy link
Author

Kloytz commented Oct 13, 2024

image

@Crystal-Spider
Copy link

Hi! I'm Soul Fire'd dev, and I wanted to add something to this.

First, I'd like to link the issue opened on my repo just to keep things organized.
Second, as I said in the screenshotted comment, the issue here is that you're compiling against the wrong version of Soul Fire'd, specifically 1.20.4-v4.0.1. This version is incompatible with 1.21.x. I will soon open a PR to fix this.

More details about the second point:

  • Amendments declares Soul Fire'd optional dependency here and here, but in both places they use this incompatible version.
  • The fix I will apply in the PR is simply to follow the up-to-date guide on how to import Soul Fire'd, which you can find here.
  • I will also remove Cobweb import from the Neoforge module as it should be useless when Soul Fire'd is imported as described above.

@Crystal-Spider
Copy link

Opened PR #143

@MehVahdJukaar
Copy link
Owner

should be fixed by that pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants