Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block textures not animated with VanillaFix #24

Open
BPplays opened this issue Jul 2, 2022 · 4 comments
Open

Block textures not animated with VanillaFix #24

BPplays opened this issue Jul 2, 2022 · 4 comments
Labels
bug Something isn't working confirmed incompatibility

Comments

@BPplays
Copy link

BPplays commented Jul 2, 2022

Describe the bug
water, lava and i would assume other animated textures

animate erratically sometimes a couple frames slowly, sometimes completely frozen

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'flowing water'
  2. see 'flowing water' not animating correctly

Versions
Nothirium: 1.12.2-0.1.6-beta
RenderLib: 1.12.2-1.1.0
Forge: 14.23.5.2860
Minecraft: 1.12.2
Other mods (necessary to reproduce the bug):
[MixinCompat-0.8].jar
[1.12.2] SecurityCraft v1.8.20.2.jar
3d-Ladders-mod-MC-1-12-2-version-1-4 (1).jar.disabled AIImprovements-1.12-0.0.1b3.jar
appliedenergistics2-rv6-stable-7.jar AquaAcrobatics-1.14.1.jar Aroma1997Core-1.12.2-2.0.0.2.jar AromaBackup-1.12.2-2.1.1.4.jar AttributeFix-1.12.2-1.0.10.jar AutoDropper-1.12.2-2.0.1.jar AutoRegLib-1.3-32.jar
BadMobs-1.12.2-1.1.40.jar
betterbiomeblend-1.12.2-1.1.7-forge.jar
BetterBuildersWands-1.12.2-0.13.2.271+5997513.jar
BetterFoliage-MC1.12-2.2.0.jar
BetterFps-1.4.8.jar
BetterPingDisplay-1.12.2-1.0.jar
BiblioCraft[v2.4.6][MC1.12.2].jar
BiomesOPlenty-1.12.2-7.0.1.2444-universal.jar
Bloodmoon-MC1.12.2-1.5.3.jar
Born In A Barn V1.8-1.12-1.1.jar
buildcraft-all-7.99.24.8.jar.disabled
cc-tweaked-1.12.2-1.89.2.jar
ChestTransporter-1.12.2-2.8.8.jar
ChickenChunks-1.12.2-2.4.2.74-universal.jar
Clumps-3.1.2.jar
CodeChickenLib-1.12.2-3.2.3.358-universal.jar
collective-1.12.2-3.0.jar
CommonCapabilities-1.12.2-2.4.8.jar
connectedglass-1.1.3-mc1.12.jar
Controlling-3.0.10.jar
coroutil-1.12.1-1.2.37.jar
CosmeticArmorReworked-1.12.2-v5a.jar
CraftTweaker2-1.12-4.1.20.675.jar
CTM-MC1.12.2-1.0.2.31.jar
CyclopsCore-1.12.2-1.6.7.jar
DayZombiez.jar
DefaultSettings-1.8.x-1.12.x-2.2.4.jar
doubledoors_1.12.2-2.5.jar
DynamicSurroundings-1.12.2-3.6.2.1.jar
EnderCore-1.12.2-0.5.76.jar
EnderIO-1.12.2-5.3.70.jar
Entifier-2.0.0.jar
EntityCulling-1.12.2-6.0.2.jar
ExperienceBugFix-1.12.2-1.0.0.0.jar
FastFurnace-1.12.2-1.3.1.jar
FastWorkbench-1.12.2-1.7.3.jar
filelist.txt
foamfix-0.10.14-1.12.2.jar
Forgelin-1.8.4.jar
ForgeMultipart-1.12.2-2.6.2.83-universal.jar
ForgeRocks-6.28.2-1.12.2-full.jar
fp2-0.0.1.612-1.12.2.jar.disabled
FullscreenWindowed-1.12-1.6.0.jar
furniture-6.3.1-1.12.2.jar
future-mc-0.2.10.jar
Hwyla-1.8.26-B41_1.12.2.jar
iChunUtil-1.12.2-7.2.2.jar
ImmersiveCables-1.12.2-1.3.2.jar
ImmersiveEngineering-0.12-98.jar
incontrol-1.12-3.9.18.jar
industrialcraft-2-2.8.170-ex112.jar
insomniac-1.6.jar
IntegratedCrafting-1.12.2-1.0.10.jar
IntegratedDynamics-1.12.2-1.1.11.jar
IntegratedTunnels-1.12.2-1.6.14.jar
InventoryTweaks-1.63.jar jei_1.12.2-4.16.1.302.jar
JustEnoughResources-1.12.2-0.9.2.60.jar
LLOverlayReloaded-1.1.6-mc1.12.2.jar
MatterOverdrive-1.12.2-0.7.1.0-universal.jar
mcjtylib-1.12-3.5.4.jar
MCMultiPart-2.5.3.jar
mcw-doors-1.0.3-mc1.12.2.jar
mcw-fences-1.0.0-mc1.12.2.jar
mcw-furniture-1.0.1-mc1.12.2beta.jar
mcw-windows-1.0.0-mc1.12.2.jar
Mekanism-1.12.2-9.8.3.390.jar
MekanismGenerators-1.12.2-9.8.3.390.jar
MekanismTools-1.12.2-9.8.3.390.jar
Mineshot-v1.71-1.12.jar
MixinBootstrap-1.0.5.jar
MobDismemberment-1.12.2-7.0.0.jar
mobsunscreen-1.12.2-2.1.3.jar
MorePlayerModels_1.12.2-(05Dec19).jar
moresoundconfig-1.0.4.jar
MouseTweaks-2.10-mc1.12.2.jar
MrTJPCore-1.12.2-2.1.4.43-universal.jar
multihotbar-1.12.2-4.0.1-build-T116.jar
multihotbarcore-1.12.2-1.0.1-build-T22.jar
NetherPortalFix_1.12.1-5.3.17.jar
NiftyBlocks-1.20.1.jar
NoFov-MC1.12-1.0.1.jar
NotEnoughItems-1.12.2-2.4.3.245-universal.jar
Nothirium-1.12.2-0.1.6-beta.jar
NuclearCraft-2o.6.1-1.12.2.jar
omlib-1.12.2-3.1.5-256.jar
ompd-1.12.2-3.1.1-76.jar
OpenBlocks-1.12.2-1.8.1.jar
OpenComputers-MC1.12.2-1.7.5.192.jar
OpenLightsController-1.0.1.jar
OpenModsLib-1.12.2-0.12.2.jar
openmodularturrets-1.12.2-3.1.14-382.jar
OreLib-1.12.2-3.6.0.1.jar
particleculling-1.12.2-v1.3.1.jar
performant-1.11.jar
PeripheralsPlusOne-1.12.2-1.2-build-T71.jar
phosphor-1.12.2-0.2.6+build50-universal.jar
Ping-1.12.2-1.4.5.jar
practicallogistics2-1.12.2-3.0.8-11.jar
ProjectRed-1.12.2-4.9.4.120-Base.jar
ProjectRed-1.12.2-4.9.4.120-fabrication.jar
ProjectRed-1.12.2-4.9.4.120-integration.jar
Quark-r1.6-179.jar
rad-1.12-1.1.0.jar
railcraft-12.0.0.jar
randompatches-1.12.2-1.22.1.10.jar
randomtweaks-1.12.2-2.8.3.1.jar
realrender-1.2.3.jar.disabled
ReAuth-1.12-Forge-4.0.3.jar
RenderLib-1.12.2-1.1.0.jar
rsgauges-1.12.2-1.2.6.jar
scalingguis-1.12.2-1.0.3.0.jar
sit-1.12.2-v1.3.jar
snowvariants-1.12.2-1.3.1.jar
sonarcore-1.12.2-5.0.19-20.jar
SpartanShields-1.12.2-1.5.4.jar
SpartanWeaponry-1.12.2-beta-1.3.8.jar
Surge-1.12.2-2.0.79.jar
switchbow-1.6.jar
TexFix V-1.12-4.0.jar
TheFramework-1.12.2-1.0.1-build-T23.jar
ToolBelt-1.12.2-1.9.13.jar
ToughAsNails-1.12.2-3.1.0.141-universal.jar
Translocators-1.12.2-2.5.2.81-universal.jar
Uppers-0.0.6.jar
VanillaFix-1.0.10-150.jar
Wawla-1.12.2-2.6.275.jar
zombieawareness-1.12.1-1.11.16.jar
ChickenASM-1.12-1.0.2.7.jar
ImmersiveEngineering-core-0.12-98.jar
ImmersiveEngineering-core-0.12-98.jar.meta
EnderCore-1.12.2-0.5.76-core.jar
EnderCore-1.12.2-0.5.76-core.jar.meta
mcjtytools-0.0.21.jar
mcjtytools-0.0.21.jar.meta
moresoundconfig-core-1.0.4.jar
moresoundconfig-core-1.0.4.jar.meta
AutoConfig-1.12.2-1.0.2.jar
AutoConfig-1.12.2-1.0.2.jar.meta
AutoSave-1.12.2-1.0.11.jar
AutoSave-1.12.2-1.0.11.jar.meta

Hardware
CPU: r9 5950x
RAM: 64gb
GPU: rtx 3090
VRAM: 24gb

Log File
Please use a paste site to upload the log file (for example https://gist.github.com/) and provide the link to the file here: https://gist.github.com/BPplays/01e12d4c79e0b048e1a7b7cdd97657cf

@BPplays BPplays added the bug Something isn't working label Jul 2, 2022
@Meldexun
Copy link
Owner

Meldexun commented Jul 3, 2022

Works fine for me with only Nothirium (+ depdencies) installed. Please reproduce the issue with as few mods as possible.

@MineyShadow
Copy link

I have tested this with nothirium, renderlib, mixinbootstrap and vanillafix and it seems to be an incompatibility with vanillafix's texture optimizations. Disabling the feature in config fixes the issue but reduces FPS in large modpacks (Not sure if this applies to similar mods that has the same feature).

Assuming it applies to most/all animated textures, i have seen it apply to: Fire, water, lava and nether portal textures, including modded portals such as betweenlands portal.

@gatoborrachon
Copy link

it seems to be an incompatibility with vanillafix's texture optimizations

yeah, this is the issue, this will also happen if you have the Texture Optimizations of CensoredASM (a performance mod that replaces VanillaFix entirely and even has more optimizations than VanillaFix)

@Meldexun Meldexun changed the title water and lava animating incorrectly Block textures not animated with VanillaFix Jul 13, 2022
@tribes33
Copy link

Hey guys, you can make CensoredASM work with Nothirium and have the textures animate, in the .cfg file and set B:onDemandAnimatedTextures to false, I also disabled B:releaseSpriteFramesCache but I dont think this one has anything to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed incompatibility
Projects
None yet
Development

No branches or pull requests

5 participants