Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API version should be a configuration #12

Open
MeltyBot opened this issue Nov 4, 2021 · 2 comments
Open

API version should be a configuration #12

MeltyBot opened this issue Nov 4, 2021 · 2 comments
Labels
accepting merge requests kind::feature migrated from gitlab valuestream::ecosystem

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented Nov 4, 2021

Migrated from GitLab: https://gitlab.com/meltano/tap-salesforce/-/issues/13

Originally created by @bwise on 2021-11-04 16:04:51

API version is currently hard coded in the tap (https://gitlab.com/meltano/tap-salesforce/-/blob/master/tap_salesforce/salesforce/__init__.py#L212)
This should be a configuration option.

Impact: I noticed I was missing fields in my replication of Salesforce records. This was fundamentally caused by the api version being too low for the field I wanted to replicate.
@MeltyBot
Copy link
Contributor Author

View 1 previous comment from the original issue on GitLab

@s7clarke10
Copy link
Contributor

I totally support this change, would be a fairly quick change rather than making changes like this : #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting merge requests kind::feature migrated from gitlab valuestream::ecosystem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s7clarke10 @MeltyBot