Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update SFDC REST api to v60 (Spring 24release) #53

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jaredgj
Copy link
Contributor

@jaredgj jaredgj commented Feb 12, 2024

Would like to Update the REST API to it's latest version.

@jaredgj jaredgj changed the title Update SFDC REST api to v60 (Srping 24release chore: Update SFDC REST api to v60 (Spring 24release) Feb 12, 2024
@pnadolny13
Copy link

@jaredgj thanks for the PR! Have you been able to verify in the API changelog about whether there are any breaking changes between API versions? Or have you tested the tap with your change and had success? I see we are on Winter 22' so this upgrades 7 releases but I have no idea how much changes between releases.

@jaredgj
Copy link
Contributor Author

jaredgj commented Feb 14, 2024

@pnadolny13 Great questions, I've been able to test the tap change and it has not broken my existing jobs. As sfor the breaking changes here are the release notes and the v60 release notes. No breaking changes I can see save for Apex REST API HTTP ACCEPT headers now default to JSON which doesn't seem breaking.

@jaredgj
Copy link
Contributor Author

jaredgj commented Feb 15, 2024

@pnadolny13 does my above answer suffice?

@pnadolny13
Copy link

@jaredgj thanks for sharing those links. I also browsed through them and didnt see anything that would cause a breaking change. That and the fact that you've been able to run it without issues seems like we should be good to merge this.

@pnadolny13 pnadolny13 self-requested a review February 20, 2024 14:32
@pnadolny13 pnadolny13 merged commit dffaae0 into MeltanoLabs:main Feb 20, 2024
1 of 2 checks passed
nezd pushed a commit to dext/tap-salesforce that referenced this pull request Sep 26, 2024
Would like to Update the REST API to it's latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants