Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer serde override as config option #18

Open
andrewcstewart opened this issue Jun 21, 2021 · 4 comments
Open

Offer serde override as config option #18

andrewcstewart opened this issue Jun 21, 2021 · 4 comments

Comments

@andrewcstewart
Copy link
Collaborator

Use case: user may want to select alternative serde.

  • org.apache.hive.hcatalog.data.JsonSerDe
  • org.openx.data.jsonserde.JsonSerDe
@visch
Copy link
Member

visch commented Oct 26, 2021

I wonder if the default should switch to a JSON file instead of a csv, re #27

@andrewcstewart
Copy link
Collaborator Author

@visch - Yes that is what I would recommend for now. The CSV serialization logic is inherited from the target that this was originally cloned from.

See also #6

@visch
Copy link
Member

visch commented Oct 28, 2021

@visch - Yes that is what I would recommend for now. The CSV serialization logic is inherited from the target that this was originally cloned from.

See also #6

Got it! So a pr changing the default, and adding to the readme? Does that seem like the best next steps @andrewcstewart ?

@andrewcstewart
Copy link
Collaborator Author

If you want to, yes that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewcstewart @visch