Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config property/setting for add_record_metadata #35

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

freimer
Copy link

@freimer freimer commented Dec 2, 2021

Problem

Fixes issue #34 . wrong config property/setting was used to add metadata. It is add_record_metadata, not add_metadata_columns. Tested on my own data pipelines and it works with this simple change.

Proposed changes

Change config property/setting from add_metadata_columns to add_record_metadata

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Copy link

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freimer Great catch! Looks good to me.

@aaronsteers
Copy link

@freimer - Thanks for this contribution! 👍 Looks good! 🚢

@aaronsteers aaronsteers merged commit af2772c into MeltanoLabs:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants