Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

OS X interface list too limited #94

Open
banks opened this issue Apr 23, 2014 · 1 comment
Open

OS X interface list too limited #94

banks opened this issue Apr 23, 2014 · 1 comment

Comments

@banks
Copy link

banks commented Apr 23, 2014

The comment here says it all ;)

https://github.com/datasift/storyplayer/blob/develop/src/php/DataSift/Storyplayer/PlayerLib/StoryContext.php#L213-L214

en0 and en1 are generally used for first two physical interfaces. On most Macs that will be built-in WiFi and built in Ethernet port.

So story player works great for me if I am connected to WiFi. But at my workstation when I plug in cinema display with it's fixed Ethernet cable (en4), story player stops working. Actually that's not quite true - it works as long as wifi is turned on (even though I'm actually using ethernet connection). Same would happen with any other network device (Bluetooth is en3, other USB or similar devices would presumably have higher numbers)

The simplest thing that would avoid confusing others in future woul be to bump up the en* ones tried in the line linked above. up to en4 would work for me I'd assume having a cinema display is not that uncommon (perhaps turning of WiFi is...). Not sure how you would decide where to stop though...

Dunno if you want to bump up the numbers you check to catch this case? It's probably rareish but it's pretty confusing when it comes up. Seems less than ideal that changing wifi status when I'm not even using WiFi makes my test framework stop running...

@stuartherbert
Copy link
Collaborator

We've overhauled this code for Storyplayer-2.0.0. I don't have a cinema display to test on, but hopefully we've fixed this bug for you now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants