Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combos of animated emotes aren't live updated for the "animate forever" setting. #37

Open
JoannesJ opened this issue Oct 20, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@JoannesJ
Copy link
Contributor

Very minor, but the non combo animated emotes ARE updated when changing the setting.

To clarify combos do animate forever when the "animate forever" setting is already on.
It's when there is already a combo in chat that it isn't updated when changing the setting.

@xDashh
Copy link
Member

xDashh commented Nov 1, 2018

I think the live-application is broken entirely. Not sure since when...

@JoannesJ
Copy link
Contributor Author

JoannesJ commented Nov 1, 2018

Got deleted during the merge.
Seems like the linting made things difficult.

@kenany
Copy link
Member

kenany commented Nov 1, 2018

Separate bug?

@JoannesJ
Copy link
Contributor Author

JoannesJ commented Nov 1, 2018

@kenany Not sure what you are asking.
But both issues point to the same piece of code; can be fixed in one go.

@kenany
Copy link
Member

kenany commented Nov 1, 2018

I thought:

  • the original issue was that combos are not updated when the setting changes, but non-combo emotes are updated
  • @xDashh's issue is that nothing is being updated when the setting changes

But yeah, these could be fixed in one go, but bringing back the removed code would not fix the original issue, since that has always been present.

@kenany kenany added the bug Something isn't working label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants