-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRAN pre-tests #296
Comments
Hi @jdblischak and @nanxstats, do you happen to know the reason for causing |
I thought we fixed that NOTE with 3af0371 (explanation in #294 (comment)). Could you please check your local |
We can't use Line 66 in ce4f1a2
If {simtrial} truly requires the latest version of {gsDesign2}, then we'll need to submit {gsDesign2} to CRAN first. Once it has been accepted, then we can remove the |
Also, as you make the final preparations for CRAN, don't forget about the minor documentation updates in PR #295 |
The remotes has been removed. |
I don't follow. Are you saying that you removed it locally and are going to send a PR? Because it definitely exists for the tag v0.4.2: https://github.com/Merck/simtrial/blob/v0.4.2/DESCRIPTION#L66 |
I am preparing v0.4.3 for CRAN resubmission with remotes deleted, since simtrial does not always require the latest gsDesign2 in GitHub master. |
The text was updated successfully, but these errors were encountered: