sim_gs_n: combine hetergenous test columns, fill missing with NAs #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
force-pushed
the
sim-gs-n-het-cols
branch
from
8f4f130
to
4e5b12a
Compare
LittleBeannie
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #273. Now that
wlr()returns different columns compared tormst()andmilestone()(and thus the outputs are no longer standardized, #222), @LittleBeannie suggested filling the missing columns withNAs (#273 (comment)).This PR replaces
rbind()withdata.table::rbindlist()to allow combining test functions that return different functions. I restored thesim_gs_n()tests to confirm this is working.Note that unfortunately it is still not possible to combine the results of
maxcombo()because itszcolumn is a list column. I think I'll be able to get this working, but it will require additional code and tests, so I decided to keep it separate from this PR.xref: #229, #258