Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document all columns returned by get_fx_groups() #90

Open
Aariq opened this issue Dec 1, 2023 · 1 comment · May be fixed by #114
Open

Document all columns returned by get_fx_groups() #90

Aariq opened this issue Dec 1, 2023 · 1 comment · May be fixed by #114
Labels
difficulty: low documentation Improvements or additions to documentation

Comments

@Aariq
Copy link
Collaborator

Aariq commented Dec 1, 2023

I think it would be good to create a short vignette that just describes what each of the functional groups is. This would be paraphrased from Pankow & Asher. I think this is important because a couple of them have very particular definitions that you might not just guess from the column name.
@Aariq Aariq added the documentation Improvements or additions to documentation label Dec 1, 2023
@Aariq
Copy link
Collaborator Author

Aariq commented Aug 5, 2024 •
edited
Loading

The vignette/article could also include drawings of SMARTS strings used. Drawings can be generated with SMARTS.plus API: https://smarts.plus/rest

@Aariq Aariq mentioned this issue Aug 6, 2024
Open
@Aariq Aariq linked a pull request Sep 25, 2024 that will close this issue
Move SMARTS patterns to a .csv file #114
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: low documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move SMARTS patterns to a .csv file Meredith-Lab/volcalc
1 participant
@Aariq