Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix upload path and error scenario #26

Merged

Conversation

jd
Copy link
Member

@jd jd commented Feb 12, 2025

The current code uploads in a different endpoint and the test is getting
a 404.

The Mergify CLI works differently and does not fail on upload issues to
avoid blocking user CI; adapt the scenario.

Copy link
Contributor

mergify bot commented Feb 12, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@jd jd changed the title ci: fix upload path ci: fix upload path and error scenario Feb 12, 2025
@jd jd force-pushed the devs/jd/fix-tests/I86797df95e04d6abc2858c57346e73f04ada430d branch 2 times, most recently from 6d8a495 to 6b6def9 Compare February 12, 2025 08:59
The current code uploads in a different endpoint and the test is getting
a 404.

The Mergify CLI works differently and does not fail on upload issues to
avoid blocking user CI; adapt the scenario.

Change-Id: I86797df95e04d6abc2858c57346e73f04ada430d
@jd jd force-pushed the devs/jd/fix-tests/I86797df95e04d6abc2858c57346e73f04ada430d branch from 6b6def9 to 1e8511b Compare February 12, 2025 09:08
@mergify mergify bot requested a review from a team February 12, 2025 09:11
@mergify mergify bot requested a review from a team February 12, 2025 09:18
mergify bot added a commit that referenced this pull request Feb 12, 2025
@mergify mergify bot added the queued label Feb 12, 2025
@mergify mergify bot merged commit 81c6a15 into main Feb 12, 2025
7 checks passed
@mergify mergify bot removed the queued label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants