Fix CTAs & Signup Page #1722
Merged
Fix CTAs & Signup Page #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Player Sign up needs fixing on mobile: ** |
Screen.Recording.2024-02-05.at.04.41.56.movUnfortunately. I'm still having trouble with mobile view, the page cuts off on the sides, and cuts off at the bottom, there's also a double scroll so that when you reach the end of the inner container, you need to scroll on the outer container. |
Seroxdesign
requested changes
Feb 5, 2024
|
Any updates? @nitegeist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
Makes requested for the guilds signup page including style and copy changes
Please provide the GitHub issue number
Fixes for https://github.com/MetaFam/MetaBrain/blob/main/Before%20Launch.md#2-fixing-ctas--patron-perks-on-signup-pages & https://github.com/MetaFam/MetaBrain/blob/main/Before%20Launch.md#14-guilds-signup-less-cramped
Closes #
Follow up Improvement Ideas
Implementation
Describe technical (nontrivial / non-obvious) parts of your code
Side effects
Assets
[Include screenshots/videos if it makes reviewing easier.]