This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add Vault class #222
Draft
Add Vault class #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
added
team-accounts
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
legobeat
reviewed
May 11, 2023
| @@ -80,7 +80,7 @@ jobs: | |||
| - prepare | |||
| strategy: | |||
| matrix: | |||
| node-version: [14.x, 16.x, 18.x, 19.x] | |||
There was a problem hiding this comment.
Does this break node14? In either case: Separate change.
legobeat
reviewed
May 29, 2023
Comment on lines
+491
to
+492
| * If a state is given, the vault will be restored form it, otherwise, a new | ||
| * vault will be created. |
There was a problem hiding this comment.
Suggested change
| * If a state is given, the vault will be restored form it, otherwise, a new | |
| * vault will be created. | |
| * If a state is supplied, the originating vault will be restored. | |
| * Otherwise, a new vault will be initialized. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Vaultclass that will be used in the vault refactor.The end goal of the refactor is to move the encryption logic out of the
KeyringControllerinto a separate class. This is the first step in this direction.This PR doesn't modify the
KeyringController, it will be done after the controller is migrated to theBaseControllerV2.Closes #208