Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add diffInternalScopesObject and export #5052

Closed
wants to merge 3 commits into from
Closed

add diffInternalScopesObject and export #5052

wants to merge 3 commits into from

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Dec 10, 2024 •
edited
Loading

Explanation

References

Extension: MetaMask/metamask-extension#29079

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi
Copy link
Contributor Author

jiexi commented Dec 10, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "20.0.1-preview-afdccab2",
  "@metamask-previews/address-book-controller": "6.0.2-preview-afdccab2",
  "@metamask-previews/announcement-controller": "7.0.2-preview-afdccab2",
  "@metamask-previews/approval-controller": "7.1.1-preview-afdccab2",
  "@metamask-previews/assets-controllers": "45.1.1-preview-afdccab2",
  "@metamask-previews/base-controller": "7.0.2-preview-afdccab2",
  "@metamask-previews/build-utils": "3.0.2-preview-afdccab2",
  "@metamask-previews/chain-controller": "0.2.1-preview-afdccab2",
  "@metamask-previews/composable-controller": "10.0.0-preview-afdccab2",
  "@metamask-previews/controller-utils": "11.4.4-preview-afdccab2",
  "@metamask-previews/ens-controller": "15.0.1-preview-afdccab2",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-afdccab2",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-afdccab2",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-afdccab2",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-afdccab2",
  "@metamask-previews/keyring-controller": "19.0.1-preview-afdccab2",
  "@metamask-previews/logging-controller": "6.0.3-preview-afdccab2",
  "@metamask-previews/message-manager": "11.0.3-preview-afdccab2",
  "@metamask-previews/multichain": "1.1.2-preview-afdccab2",
  "@metamask-previews/name-controller": "8.0.2-preview-afdccab2",
  "@metamask-previews/network-controller": "22.1.1-preview-afdccab2",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-afdccab2",
  "@metamask-previews/permission-controller": "11.0.4-preview-afdccab2",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-afdccab2",
  "@metamask-previews/phishing-controller": "12.3.1-preview-afdccab2",
  "@metamask-previews/polling-controller": "12.0.2-preview-afdccab2",
  "@metamask-previews/preferences-controller": "15.0.1-preview-afdccab2",
  "@metamask-previews/profile-sync-controller": "3.0.0-preview-afdccab2",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-afdccab2",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-afdccab2",
  "@metamask-previews/remote-feature-flag-controller": "1.1.0-preview-afdccab2",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-afdccab2",
  "@metamask-previews/signature-controller": "23.1.0-preview-afdccab2",
  "@metamask-previews/transaction-controller": "42.0.0-preview-afdccab2",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-afdccab2"
}

@jiexi
Copy link
Contributor Author

jiexi commented Dec 10, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "20.0.1-preview-8b348690",
  "@metamask-previews/address-book-controller": "6.0.2-preview-8b348690",
  "@metamask-previews/announcement-controller": "7.0.2-preview-8b348690",
  "@metamask-previews/approval-controller": "7.1.1-preview-8b348690",
  "@metamask-previews/assets-controllers": "45.1.1-preview-8b348690",
  "@metamask-previews/base-controller": "7.0.2-preview-8b348690",
  "@metamask-previews/build-utils": "3.0.2-preview-8b348690",
  "@metamask-previews/chain-controller": "0.2.1-preview-8b348690",
  "@metamask-previews/composable-controller": "10.0.0-preview-8b348690",
  "@metamask-previews/controller-utils": "11.4.4-preview-8b348690",
  "@metamask-previews/ens-controller": "15.0.1-preview-8b348690",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-8b348690",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-8b348690",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-8b348690",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-8b348690",
  "@metamask-previews/keyring-controller": "19.0.1-preview-8b348690",
  "@metamask-previews/logging-controller": "6.0.3-preview-8b348690",
  "@metamask-previews/message-manager": "11.0.3-preview-8b348690",
  "@metamask-previews/multichain": "1.1.2-preview-8b348690",
  "@metamask-previews/name-controller": "8.0.2-preview-8b348690",
  "@metamask-previews/network-controller": "22.1.1-preview-8b348690",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-8b348690",
  "@metamask-previews/permission-controller": "11.0.4-preview-8b348690",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-8b348690",
  "@metamask-previews/phishing-controller": "12.3.1-preview-8b348690",
  "@metamask-previews/polling-controller": "12.0.2-preview-8b348690",
  "@metamask-previews/preferences-controller": "15.0.1-preview-8b348690",
  "@metamask-previews/profile-sync-controller": "3.0.0-preview-8b348690",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-8b348690",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-8b348690",
  "@metamask-previews/remote-feature-flag-controller": "1.1.0-preview-8b348690",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-8b348690",
  "@metamask-previews/signature-controller": "23.1.0-preview-8b348690",
  "@metamask-previews/transaction-controller": "42.0.0-preview-8b348690",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-8b348690"
}

@jiexi
Copy link
Contributor Author

jiexi commented Dec 11, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "20.0.1-preview-a9d27825",
  "@metamask-previews/address-book-controller": "6.0.2-preview-a9d27825",
  "@metamask-previews/announcement-controller": "7.0.2-preview-a9d27825",
  "@metamask-previews/approval-controller": "7.1.1-preview-a9d27825",
  "@metamask-previews/assets-controllers": "45.1.1-preview-a9d27825",
  "@metamask-previews/base-controller": "7.0.2-preview-a9d27825",
  "@metamask-previews/build-utils": "3.0.2-preview-a9d27825",
  "@metamask-previews/chain-controller": "0.2.1-preview-a9d27825",
  "@metamask-previews/composable-controller": "10.0.0-preview-a9d27825",
  "@metamask-previews/controller-utils": "11.4.4-preview-a9d27825",
  "@metamask-previews/ens-controller": "15.0.1-preview-a9d27825",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-a9d27825",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-a9d27825",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-a9d27825",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-a9d27825",
  "@metamask-previews/keyring-controller": "19.0.1-preview-a9d27825",
  "@metamask-previews/logging-controller": "6.0.3-preview-a9d27825",
  "@metamask-previews/message-manager": "11.0.3-preview-a9d27825",
  "@metamask-previews/multichain": "1.1.2-preview-a9d27825",
  "@metamask-previews/name-controller": "8.0.2-preview-a9d27825",
  "@metamask-previews/network-controller": "22.1.1-preview-a9d27825",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-a9d27825",
  "@metamask-previews/permission-controller": "11.0.4-preview-a9d27825",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-a9d27825",
  "@metamask-previews/phishing-controller": "12.3.1-preview-a9d27825",
  "@metamask-previews/polling-controller": "12.0.2-preview-a9d27825",
  "@metamask-previews/preferences-controller": "15.0.1-preview-a9d27825",
  "@metamask-previews/profile-sync-controller": "3.0.0-preview-a9d27825",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-a9d27825",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-a9d27825",
  "@metamask-previews/remote-feature-flag-controller": "1.1.0-preview-a9d27825",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-a9d27825",
  "@metamask-previews/signature-controller": "23.1.0-preview-a9d27825",
  "@metamask-previews/transaction-controller": "42.0.0-preview-a9d27825",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-a9d27825"
}

@jiexi jiexi mentioned this pull request Dec 11, 2024
Closed
7 tasks
@jiexi
Copy link
Contributor Author

jiexi commented Dec 16, 2024

Let's pass on this for now

@jiexi jiexi closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiexi