Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Sign typed data v1/v3 error to be updated for OneKey devices #13098

Open
vivek-consensys opened this issue Jan 21, 2025 · 0 comments
Open

[Bug] Sign typed data v1/v3 error to be updated for OneKey devices #13098

vivek-consensys opened this issue Jan 21, 2025 · 0 comments
Assignees
@Akaryatrh
Labels
hardware-onekey INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-hardware-wallets type-bug Something isn't working

Comments

@vivek-consensys
Copy link
Contributor

Build: MetaMask/metamask-extension#29610

  1. Install MM Extension
  2. Recover from SRP
  3. Add hardware wallet [OneKey]
  4. Add 2x OneKey accounts
  5. Launch test-dapp
  6. Connect to OneKey account
  7. Sign typed data v1 and verify error
  8. Sign typed data v3 and verify error

Expected: Result: Error: Keyring Controller signTypedMessage: Error: OneKey: Only version 4 of typed data signing is supported

Actual: Result: Error: Keyring Controller signTypedMessage: Error: Trezor: Only version 4 of typed data signing is supported

image.png
@vivek-consensys vivek-consensys added Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-hardware-wallets type-bug Something isn't working hardware-onekey labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 21, 2025
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akaryatrh Akaryatrh

Labels
hardware-onekey INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-hardware-wallets type-bug Something isn't working
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Akaryatrh @metamaskbot @vivek-consensys