Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticPropV10 size should be 72 #63

Open
cr4yz opened this issue Mar 7, 2019 · 5 comments
Open

StaticPropV10 size should be 72 #63

cr4yz opened this issue Mar 7, 2019 · 5 comments

Comments

@cr4yz
Copy link

cr4yz commented Mar 7, 2019

[StructLayout(LayoutKind.Sequential, Pack = 1, Size = 76)]

Had some issues reading props, size here should be 72

edit: this is the map I tested with, it's using v10
https://gamebanana.com/maps/188524

@Metapyziks
Copy link
Owner

Thanks for reporting!

@Metapyziks
Copy link
Owner

Ah to complicate things a bit, this map is also v10 but only works with Size=76 😕
https://steamcommunity.com/sharedfiles/filedetails/?id=1667954510

@Metapyziks Metapyziks reopened this Mar 10, 2019
@cr4yz
Copy link
Author

cr4yz commented Mar 10, 2019

I checked out bspsrc and it looks like csgo is a special case, 76 for v10 and 80 for v11.

https://github.com/ata4/bspsrc/blob/ddc92cf9979b3e9f39a625e0ecfa963edce7071d/src/main/java/info/ata4/bsplib/BspFileReader.java#L366

edit: I hacked in a fix that checks if the bsp Version is 21, since I only plan on loading CS:S and CS:GO maps this will work for me. For a complete solution looks like it'll need to determine if the map is specifically for CS:GO, since other games with version 21 don't use the same struct

Metapyziks added a commit that referenced this issue Mar 10, 2019
@Metapyziks
Copy link
Owner

I've used that as a workaround too, maybe we'll figure out a better way to detect CS:GO maps later.

@cr4yz
Copy link
Author

cr4yz commented Mar 10, 2019

Cool, thanks for the update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants