Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdo-table overrides function from another module at runtime #32

Open
jonasjucker opened this issue Jul 16, 2024 · 0 comments
Open

cdo-table overrides function from another module at runtime #32

jonasjucker opened this issue Jul 16, 2024 · 0 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@jonasjucker
Copy link
Collaborator

The command cdo-table overrides a function from another module.

model_output_parser.dataframe_from_ncfile = rel_diff_stats

This alters the behaviour of all other probtests-command relying on that method.

@jonasjucker jonasjucker added bug Something isn't working invalid This doesn't seem right labels Jul 16, 2024
@jonasjucker jonasjucker mentioned this issue Jul 16, 2024
jonasjucker added a commit that referenced this issue Jul 17, 2024
Replace `e2e` tests with a new set of tests that is independent of ICON
data. These tests basically tests the command-line interfaces of the
click-subcommand. So far `cdo-table`, `tolerance`, `perturb`,
`performance` and `stats` are covered.

### Pytest fixtures
In order to handle data requirements of the tests a set of fixtures is
used.
This allows to organize the data requirements of the tests in a central
place.

### Execute all tests using Pytest
In order to start transition to pytests, collect and execute all tests
using pytest

### Reference files in `tests/data`
The tests compare its results to precomputed values located in the repo.
This ensures consistency over time. In case new reference data is
required, pytests automatically stores
the new references for each test-session in a folder in `/tmp`. The
location is printed to terminal
when running pytest.

### cdo-table overrides function at runtime
See #32,
a quick and dirty fix has been introduce in the PR.

---------

Co-authored-by: Jonas Jucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant