-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package for inclusion - vsivsi:job-collection #30
Comments
Have you looked on jobs from Max Savin? https://github.com/msavin/SteveJobs |
Also I think at this point we need to get things moving on packages that we have move into the org before admitting any new packages. |
We have people interested in maintaining, and they are already doing that in their fork, so not sure why making it more official and organized would be a bad thing? |
vsivsi:job-collection is mature and heavily battle-tested, also already written in CoffeeScript. |
@StorytellerCZ Last time I looked steve jobs package was lacking some features compared to jobs collection. Most notably jobs collection allows you to have work distributed amongst multiple servers and to have workers outside of Meteor. There's a package for pure nodejs workers or you can even have workers in any other language using a rest api to fetch jobs. |
I would hope to be able to similarly transition its sister package Sorry for being late to the discussion, I've been out of action with a terrible case of the flu for a couple of weeks. Get those shots, it's awful! |
A couple of wrinkles... The job-collection package has dependencies on some more generic node-js libs.
There are probably more. The point being that just maintaining job-collection but neglecting these other pieces will probably lead to difficulty down the line, so be aware. |
Any update on this? I've already created my own personal fork of this and am running it in production nowadays (https://atmospherejs.com/simonsimcity/job-collection). I'd like to get it back into a non-forked maintained stream. I'm also on @StorytellerCZ that we might have to do some research here to investigate on where the different job packages are good in and where the individual implementation falls short in. I'm all in for diversity, but it should be reasonable when to join which path. |
We are also using the fork from @SimonSimCity in our main product for a while now. |
Just a note on this - I am using my own fork/rewrite of msavin/sjobs, mainly due to this significant inefficiency in sjobs which is WONTFIX (every new job type/queue you create results in a 3 second My own version is much more efficient as it uses a single observer on the job queue instead of 20 db lookups every 3 seconds! Mine can also persists paused job queues across multiple servers. I haven't used job-collection and it looks awesome, but I personally would not recommend endorsing msavin/sjobs. Having said that, I wouldn't endorse mine either because I haven't written tests for it! Edit: it looks like jobs-collection uses polling as well, which in my case could be very inefficient. The readme says:
My solution to that is to use an observer to watch for changes to a query looking for the next job across all queues, and within that observer set a |
I think we can move ahead with this. Does someone want to take the lead on getting the repo transferred and setting up orgs, teams, and permissions? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Where are we about this one? |
@mitar If we have maintainers in place, feel free to move forward. |
I think maybe we could share it between @SimonSimCity and me? I am still interested in it, but at the moment a bit low on time. |
@mitar I could help with the initial setup, but I'm no longer working on a project requiring it, so I'm not all too eager investing much time into it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still planing. :-) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Unstale. |
@mitar, I am using a copied version of job-collection as a local package at the moment, but a community-hosted package would have my preference. I can help out from time to time. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale from my perspective |
The setup is no problem. @mitar and @holmrenser if you want to become the maintainers on this then that is enough for me to get this started. |
Sure thing! Let me know what I can do! |
I am still interested in this (using it in some of my legacy apps) but it seems I will not have time to do anything concrete about this anytime soon. :-( |
Proposal: @mitar and myself become maintainers, we put some (limited) effort into migrating this to meteor-community-packages as is, which I can probably mostly take care of, but might want to have some feedback from @mitar on. @StorytellerCZ what do you think? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale. Pinging @mitar and @StorytellerCZ |
@StorytellerCZ Reminder |
Alright, first step is to add |
On another note, we can now also migrate in: https://github.com/percolatestudio/meteor-synced-cron |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Package/project name & description
job-collection is a powerful and easy to use job manager designed and built for Meteor.js. It solves the following problems (and more):
Links
Current status of the project
Reasoning
I think this is the best background task package for Meteor, supporting many use cases.
Progress
communitypackages
org added as a maintainer on AtmosphereThe text was updated successfully, but these errors were encountered: