Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mra_rom_check.sh outputs so many errors that most people don't use it #52

Open
dshadoff opened this issue Jan 24, 2021 · 1 comment
Open

Comments

@dshadoff
Copy link
Member

I have worked on cleaning up most of the MRA files in the MiSTer-devel repositories in December 2020, but certain types of issues required script updates.

  1. Errors beyond one screenful were not traceable
    -> In pull request 46, this is fixed by outputting to a logfile

  2. "No MAME version" dwarfs other issues, and it is not clear where this information comes from (and it does not affect operation)
    -> This outputs to a separate logfile and is no longer directed to the screen because of the number of these issues, particularly in the Jotego MRAs, which most people have on their system. In order to make the script useable, follow-ups to Jotego's repos will also be necessary, so that this error can be re-enabled in future when it can be meaningful.

  3. Changes to how ZIP file and CRC errors are being identified, to reduce false positives.
    -> This was done by @alanswx , and put in pull request 48 (which is also now integrated into pull request 46)

@theypsilon
Copy link
Member

theypsilon commented Feb 8, 2021

I also added another PR to improve in the error feedback: #54

This time the main focus is making it useful for CI systems.

For this, I added a few possible arguments:

usage: mra_checker.py [-h] [-m MRA_FOLDER] [-f FILE] [-ir] [-ic] [-im] [-r]

optional arguments:
  -h, --help            show this help message and exit
  -m MRA_FOLDER, --mra-folder MRA_FOLDER
  -f FILE, --file FILE
  -ir, --ignore-roms
  -ic, --ignore-crc
  -im, --ignore-mameversion
  -r, --recursive

And I also I return a failure code when there was any error.

Here is an example of this being used in a CI system:
Task script: https://github.com/theypsilon/MRA-Checker_MiSTer/blob/main/install_and_check_mras.sh
Task output: https://github.com/theypsilon/MRA-Checker_MiSTer/runs/1858840621?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants