You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the issue is this short-circuit. It returns a Version object that results in an incorrect diff. (Since the Version doesn't set rev=commit like in the non-short-circuit case).
The text was updated successfully, but these errors were encountered:
I think my analysis is off. I'm having a bit of a hard time figuring out exactly what the old/new version/rev and replacement logic are. Seems like maybe the more common factor is the version format being used?
I think this more or less is caused by us passing the rev as version in some of our packages. And/or the commit that lily just reverted. Anyway, I think it's safe to close this one for now.
I actually think i spotted the issue and realized the triggers conditions at the same time.
https://github.com/Mic92/nix-update/blob/master/nix_update/version/github.py#L51
I think the issue is this short-circuit. It returns a Version object that results in an incorrect diff. (Since the Version doesn't set rev=commit like in the non-short-circuit case).
The text was updated successfully, but these errors were encountered: