Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-update (version=branch) gives wrong results for repos with no releases #276

Closed
colemickens opened this issue Sep 8, 2024 · 3 comments

Comments

@colemickens
Copy link

I actually think i spotted the issue and realized the triggers conditions at the same time.

https://github.com/Mic92/nix-update/blob/master/nix_update/version/github.py#L51

I think the issue is this short-circuit. It returns a Version object that results in an incorrect diff. (Since the Version doesn't set rev=commit like in the non-short-circuit case).

@colemickens
Copy link
Author

I think my analysis is off. I'm having a bit of a hard time figuring out exactly what the old/new version/rev and replacement logic are. Seems like maybe the more common factor is the version format being used?

@Mic92
Copy link
Owner

Mic92 commented Sep 18, 2024

Afaik our nixpkgs standard is to use 0 as the version in the case there is no release. And this is what nix-update implements.

@colemickens
Copy link
Author

I think this more or less is caused by us passing the rev as version in some of our packages. And/or the commit that lily just reverted. Anyway, I think it's safe to close this one for now.

@Mic92 Mic92 closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants