Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embossed widgets' shadows are incorrect #2

Open
nonoyona opened this issue Jan 27, 2020 · 6 comments
Open

Embossed widgets' shadows are incorrect #2

nonoyona opened this issue Jan 27, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@nonoyona
Copy link

Hey, this package is actually amazing, I really like how easy it is to implement neomorphic containers with it. I only think there is a problem with the emboss parameter in the container.
The shadow of an embossed widget actually should blur on the inside of the Container and not on the outside I guess.
I also know this is not implemented natively in flutter, but there could be a workaround for that.

@edeuss
Copy link

edeuss commented Feb 20, 2020

Yea I have noticed that too @nonoyona @mcaubrey

@MichaelCharles
Copy link
Owner

Hey there, sorry for the delay in response.

You mean something like this,

Instead of something like this,

Right?

I don't know whether or not I'd call either way right or wrong, but they definitely both have value. If someone can come up with a work around I'd definitely incorporate it as an option at least (or maybe even make it default?).

I tried to put together a workaround the other day and failed. Maybe others will have better luck than me.

@nonoyona
Copy link
Author

Hey actually I found a way to implement the first version of the panel, but it has a major drawback.
currently, the ClayContainer has the ability to have a CurveType of convex, concave or none.
With my implementation, the CurveType ist restricted to none.

Just tell if you'd like to see my implementation anyways.

@m-j-g
Copy link

m-j-g commented Jun 10, 2020

@nonoyona @mcaubrey this is interesting. (Great job on the package by the way). When I have gone through the documentation of another Neumorphic package I noticed that Emboss wasn't in addition to the curveType but another type itself. In which case @nonoyona solution wouldn't be a drawback. You would just end up with the types of Convex, Concave, Emboss, or None. I'm not sure, though, if people are mixing curve types with emboss.

@wurikiji
Copy link

wurikiji commented Jun 28, 2020

Instead of using emboss: true, using depth: -20 makes ClayContainer more like a reference version but not the same. But, I like this package's approach more 👍

image

The left one is from the flutter_neumorphic package, and the right one is from this package using depth: -20.

@MichaelCharles MichaelCharles added enhancement New feature or request help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Mar 10, 2021
@renanmgs
Copy link

renanmgs commented Jun 23, 2021

This would be awesome, but depth: -20 with Convex shape is a really nice solution too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants