Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E testing for Vault #1284

Open
NikMidas opened this issue Feb 7, 2023 · 2 comments
Open

E2E testing for Vault #1284

NikMidas opened this issue Feb 7, 2023 · 2 comments
Assignees
@vminkov

Comments

@NikMidas
Copy link
Collaborator

NikMidas commented Feb 7, 2023 •
edited by vminkov
Loading

smart contracts:
test that creates a plugin rewards delegate market and uses the vault as the plugin - make sure that a call to plugin.claim() can be made, because currently the popcorn RewardsClaimer uses harvest() as the fn to collect the rewards
@vminkov
Copy link
Contributor

vminkov commented Feb 7, 2023

smart contracts:
test that creates a plugin rewards delegate market and uses the vault as the plugin - make sure that a call to plugin.claim() can be made, because currently the popcorn RewardsClaimer uses harvest() as the fn to collect the rewards

@NikMidas NikMidas changed the title E2E testing for Vault Factory E2E testing for Vault Mar 23, 2023
@NikMidas
Copy link
Collaborator Author

NikMidas commented Mar 23, 2023 •
edited by vminkov
Loading

@vminkov

  • Accruing rewards and redist with flywheels
  • DONE: Testing rage quit logic
  • Applying performance fee
  • DONE: Limit the ability to deposit in the adapters only to the vaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vminkov vminkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vminkov @NikMidas