Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ethers to v6 #1295

Open
peetzweg opened this issue Feb 9, 2023 · 2 comments
Open

Upgrade ethers to v6 #1295

peetzweg opened this issue Feb 9, 2023 · 2 comments
Labels
🔨 [SDK] All issues related to `packages/sdk` 💄 [UI] All Issues related to `packages/ui`

Comments

@peetzweg
Copy link
Contributor

peetzweg commented Feb 9, 2023

Not sure if it's worthwhile just yet. The release is out but does not seem to be properly described yet. Best I was able to find is this:

https://docs.ethers.org/v6/migrating/

As BigNumbers have been removed, there is a lot of stuff which needs to be adapted. Also not sure how well it will work with third party libraries we use like wagmi just yet. So I guess we should stick with v5 for a while longer.

Related #1126 (comment)
@peetzweg peetzweg added 💄 [UI] All Issues related to `packages/ui` 🔨 [SDK] All issues related to `packages/sdk` labels Feb 9, 2023
@NikMidas
Copy link
Collaborator

NikMidas commented Apr 5, 2023

Blocked on UI side, WAGMI is still using v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 [SDK] All issues related to `packages/sdk` 💄 [UI] All Issues related to `packages/ui`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peetzweg @NikMidas and others