Asi 15 04 bug fixes (#305)

* last commit * latest check * new db migrations and updated passport * login with drupal support * add the rest, and lint * GUI changes * not sure how does res reach here * that cache again * cleanup * remove code duplication * fix lint * adding error handling * pass the error handling on * fixed constants.js * tmp disable travis cache for node_modules * Update passport.js * update to latest * adding test special case * no yoda notation for me T_T * Update main_routes.test.js * dddd * update test-user and raise timeout * update test-user and omit some test logic to adjust to new bizlogic of login * changed the test user no need for mock anymore * remove underscore * updated imported csv to new members_camp * commit changes * d * fixed the validated sign * some fixes, adding the EVENT_ID * removed the campDetails from all places. fixed one insert and update. update on new camp the event_id * fix for eslint * fixes * fixed for eslint * local commit * added enabled status * refine * Merge branch 'master' of https://github.com/Midburn/Spark * camps route fix * Revert "camps route fix" This reverts commit d926484. * basic members implementation * bug fix * add member form * removed unnecessary function call * fixed several small issues, with getUserCamps functions, moving the functionality from API to the User model. * fixed several small issues, with getUserCamps functions, moving the functionality from API to the User model. * manually loaded api_camps_route * test * fix * sdfsadf * change activity time to multi select * lilach location fixes * improve contact person dropdown display * facebook link size fix * data validation * lint * Changed the API commands for join & join_deliver to work with the model commands. * fix lint issues * added option to remove approve new members * lint * fixed some bugs with getUserCamps and fix security issues. * ui fixes * commit passport + approve * ddd * changes * join camp is according to lang * FB link doesn't get too long * translation fixes * added approve join request btn * added email templates * comit local changes * changes of field names for members * typo fix * updated the join camp flow, and tested * lint shit * lint shit * fixes the join system, and several bug fix * lint shit * finalized the join flow several bug was removed. still having angular issue, need to be found. * removed junk * lint * fixes issues before production, also import bugs. * show contact information good * d * changes for lint * small issues * fixed the cancel user request fixed some small security issues with users removed automatic fetch from camps_v2 added language string for all status code. * lint shit * Introduced the camp __prototype to use for other camp types. fixed the camp_location_area * fixing all hebrew titles fixed who am i introduced the camp_type schema * lint shit * changes * fixes split issue * template api_gate * fixed the members add, for admin show all camps * lint * fixed mail delivery to join request * lint * refactoring edit + new, to fix foreign key, and adding fields to edit only for admin * fixed add new camp, and adding default member. todo: after success update, forward to edit camp check if camp_name hebrew + english are not empty change selection of camp manager to be select2 input * lint * lint * lint * lint fixes * lint * latest fixes * Fixes: 1. Date format is changed to suit mysql format. 2. Now we receiving ticket information 3. Bug fix of join camp 4. spark link to support page fixed 5. added birth_date, and showing camp info on whoami only if approved * lint * trying to fix the tests * travis * Update admin_routes.test.js * ffff * remved problem tests * fixed a lot of GUI stuff: 1. Dispaly of camp desc will show also linking URL. 2. Display of camp desc will show in the formatted text. 3. Updated translation strings, where was default 4. on members list, changed buttons with description instead of just icons. * eslint * added camp_manager, camp information to email * fixed NPO form, to include english * Issue #278 Issue #277 * Add 1st sanity test * Rename npm target * Add pending test for 'forgot password' page * Fixed MIDBURN2017 Tickets type on constants * refactor emailValidate function to the common * Fixing of all emails, with the info inside. * API Gate route fixes * lint * fixing small bugs with gui * lint check
Midburn · Apr 15, 2017 · 0ee91b1 · 0ee91b1
1 parent 6cc3d35
commit 0ee91b1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/routes/api_camps_routes.js b/routes/api_camps_routes.js
@@ -228,7 +228,7 @@ module.exports = (app, passport) => {
         var __update_prop = function (propName, options) {
             if (req.body[propName] !== undefined) {
                 let value = req.body[propName];
-                if (!options || (typeof options === 'array' && options.indexOf(value) > -1)) {
+                if (!options || (options instanceof Array && options.indexOf(value) > -1)) {
                     data[propName] = value;
                 }
                 return value;

diff --git a/routes/api_gate_routes.js b/routes/api_gate_routes.js
@@ -23,10 +23,10 @@ var __gate_change_status = function (user_id, status, req, res) {
 
             User.forge({ _forge }).fetch().then((user) => {
                 let addinfo_json = {};
-                if (user && (typeof user.attributes.addinfo_json) === 'string') {
+                if (user && typeof(user.attributes.addinfo_json) === 'string') {
                     addinfo_json = JSON.parse(user.attributes.addinfo_json);
                 }
-                if (typeof addinfo_json.current_status_log !== 'array') {
+                if (addinfo_json.current_status_log instanceof Array) {
                     addinfo_json.current_status_log = [];
                 }
 

diff --git a/routes/camps_routes.js b/routes/camps_routes.js
@@ -9,8 +9,9 @@ __camp_data_to_json = function (camp) {
         'camp_location_street', 'camp_location_street_time', 'camp_location_area', 'contact_person_name',
         'contact_person_email', 'contact_person_phone'];
     for (let i in camp_check_null) {
-        if (camp_data[camp_check_null[i]] === null)
+        if (camp_data[camp_check_null[i]] === null) {
             camp_data[camp_check_null[i]] = '';
+        }
     }
     return camp_data;
 }