Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly is not signed with strongname #52

Open
joseBuitragoSage opened this issue Oct 24, 2024 · 12 comments
Open

Assembly is not signed with strongname #52

joseBuitragoSage opened this issue Oct 24, 2024 · 12 comments
Assignees

Comments

@joseBuitragoSage
Copy link

I can't use de Nuget package beacouse the assembly is not signed with strongname.

@joseBuitragoSage
Copy link
Author

I'm using Framework 4.8

@Miista
Copy link
Owner

Miista commented Oct 24, 2024

Hi @joseBuitragoSage

I appreciate you reaching out. This is the first time I've experienced someone not being able to use the NuGet package due to strong naming.

I will look into it as soon as possible (tomorrow, hopefully but I can't promise).

How critical is it?

@Miista Miista self-assigned this Oct 24, 2024
@joseBuitragoSage
Copy link
Author

Thanks @Miista
I can't use this nuget. It's critical.
I've been trying all day to come up with a solution but it doesn't work.

@Miista
Copy link
Owner

Miista commented Oct 25, 2024

@joseBuitragoSage: Can you supply a minimal example I can use for reproduction?

@joseBuitragoSage
Copy link
Author

@Miista The Sample is easy,You only need to have a Unit Test project signed with strongname, you can install the Nuget package but when you try to execute it it doesn't work.

@Miista
Copy link
Owner

Miista commented Oct 31, 2024

I have been able to reproduce the issue locally. I now need to find out how to sign the assembly. I read somewhere that this is not necessary for .NET Core and upwards.

@joseBuitragoSage
Copy link
Author

I'm using framwork 4.8 and it's mandatory. You can sign the assembly in the properties of project with a snk file. You can generate this file.

@Miista
Copy link
Owner

Miista commented Nov 6, 2024

@joseBuitragoSage I apologize for the delay. I hope to get some time to look into it tomorrow.

@joseBuitragoSage
Copy link
Author

Thanks @Miista If you need something let me know

@Miista
Copy link
Owner

Miista commented Nov 15, 2024

@joseBuitragoSage I apologize for the radio silence. I've been swamped lately. I will try to prioritize it.

I don't know very much about signing assemblies with strong naming. I'm a little concerned about the impact this might have on projects targeting .NET Core.
Do you have any insight on this?

@joseBuitragoSage
Copy link
Author

joseBuitragoSage commented Nov 25, 2024

HI @Miista. The impact will be positive. In terms of security, it is better because no one will be able to modify the assembly and also the reference will be with a public key. The problem is that if you sign your assemblies, the references you use have to be signed, otherwise not.

Miista pushed a commit that referenced this issue Nov 28, 2024
@Miista
Copy link
Owner

Miista commented Nov 28, 2024

@joseBuitragoSage I have added a commit which adds strong name signing of Pose. I have yet to create a release.

I believe you could, however, check out the commit and verify it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants