Enable commands in DMs #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelSiidorow
requested changes
Aug 11, 2022
kipubot/handlers/_dm_handlers.py
Outdated
Comment on lines
14
to
18
| query_result = CON.execute( | ||
| f'SELECT R.chat_id,chat.title FROM in_chat AS C \ | ||
| JOIN raffle as R ON C.chat_id=R.chat_id JOIN\ | ||
| chat ON chat.chat_id=R.chat_id\ | ||
| WHERE C.user_id={update.effective_user.id}').fetchall() |
There was a problem hiding this comment.
F-string = can inject SQL very bad 😞
Comment on lines
-25
to
+34
| chat_id = update.effective_chat.id | ||
| chat_title = update.effective_chat.title | ||
| if update.callback_query is not None: | ||
| chat_id, chat_title, graph_type = update.callback_query.data | ||
| message = update.callback_query.message | ||
| else: | ||
| chat_id = update.effective_chat.id | ||
| chat_title = update.effective_chat.title | ||
| message = update.message |
There was a problem hiding this comment.
Joku data verification vois olla hyvä, jos botti restarttaa tms.
Esim:
if (isinstance(query.data, InvalidCallbackData) or
len(query.data) != 3 or
not isinstance(query.data[0], int) or
not isinstance(query.data[1], str) or
not isinstance(query.data[2], int)):
await query.message.edit_text(STRINGS['unknown_error'])
return ConversationHandler.END
|
closed since the structure of the program has changed drastically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabling commands in DMs:
closes #17