Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Header View #24

Open
ueen opened this issue Jun 7, 2021 · 7 comments
Open

Header View #24

ueen opened this issue Jun 7, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@ueen
Copy link

ueen commented Jun 7, 2021

If i might suggested another feature:
A different header view that is displayed as the first item would be awesome could be something like this in the builder:
addHeader(R.layout.header) { view -> ... }

And also a footer as the last item should be added.

I think then this library really suits all basic needs one can wish for 😎

@MinSeungHyun MinSeungHyun added the enhancement New feature or request label Jun 7, 2021
@ueen
Copy link
Author

ueen commented Jun 8, 2021

Here are several ways to do it https://khacpv.medium.com/android-best-practice-for-recyclerview-with-headerview-140bd4b10757
And another https://medium.com/@polson55/the-best-way-to-add-a-recyclerview-header-f29f3ff56f84

Ok I think the last one is not that good because there are problems if it gets nested, actually I think the easiest would be to handle multiple viewholder types and calculate offset, for that slush has to support multiple types (which is on the TODO) or easier would probably be to just use ConcatAdapter as described here
https://medium.com/androiddevelopers/get-ahead-using-headers-in-recyclerview-2909a69b19

@MinSeungHyun you know slush best, what do you think is the best/easiest route, add multiple holdertype support first or concat adapters?

@MinSeungHyun
Copy link
Owner

Thank you so much for helping my library 🥰
But I'm very busy these days because I have an important exam coming up at the end of this year. I'll make sure to check it out after the exam!!

@ueen
Copy link
Author

ueen commented Jun 8, 2021

You're welcome, no problem!
Let me know if you want me to work on something and do a PR 😇

@ueen
Copy link
Author

ueen commented Dec 8, 2021

Hope you did well on your exam! Any progress so far? 😊

@MinSeungHyun
Copy link
Owner

Yeah, thank you for your concerns. Unfortunately, as you can see on the description of this repository, I decided not to update this library TT
I'm sorry and thank you again!

@ueen
Copy link
Author

ueen commented Dec 9, 2021

Oh very sad to hear, you should really reconsider, this is the best/easiest library to handle recyclerviews! ❤

@MinSeungHyun
Copy link
Owner

But there is a way to maintain this library.
You can fork this repository and update it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants