Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out build script shading logic with proper shading #2

Open
Col-E opened this issue Jul 10, 2023 · 0 comments
Open

Swap out build script shading logic with proper shading #2

Col-E opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Col-E
Copy link
Collaborator

Col-E commented Jul 10, 2023

The current shade logic works fine, but ideally we want to move these classes to a sub-package.

This way if a client is using concoction and SSVM they can use their own version of SSVM without being chained to the one we shade.

When implementing this we do not want to enable minification in the shade plugin, as that can lead to problems down the road. The dependencies we bundle in are small anyways.

@Col-E Col-E added the enhancement New feature or request label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant