From db3a938cf74077d6071d91db15ba3e713b93af3d Mon Sep 17 00:00:00 2001 From: Kyle VanderBeek Date: Mon, 25 Nov 2024 15:36:54 -0800 Subject: [PATCH 1/4] Remove nav link to non-page. --- mkdocs.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/mkdocs.yml b/mkdocs.yml index f95fc1aa..91a4c361 100644 --- a/mkdocs.yml +++ b/mkdocs.yml @@ -39,7 +39,6 @@ nav: - Screens: 'gui/screens.md' - Rendering: - Model Extensions: - - Introduction: 'rendering/modelextensions/index.md' - Root Transforms: 'rendering/modelextensions/transforms.md' - Render Types: 'rendering/modelextensions/rendertypes.md' - Part Visibility: 'rendering/modelextensions/visibility.md' From 04c4bf48f03665caf0f1eba4c9733dbf356cae5a Mon Sep 17 00:00:00 2001 From: Kyle VanderBeek Date: Mon, 25 Nov 2024 15:39:08 -0800 Subject: [PATCH 2/4] Correct errant anchors. --- docs/datastorage/codecs.md | 4 ++-- docs/misc/gametest.md | 2 +- docs/resources/client/index.md | 2 +- docs/resources/server/glm.md | 2 +- docs/resources/server/index.md | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/datastorage/codecs.md b/docs/datastorage/codecs.md index e948eb3c..a5ea498e 100644 --- a/docs/datastorage/codecs.md +++ b/docs/datastorage/codecs.md @@ -224,7 +224,7 @@ public static final Codec INT_CODEC = Codec.STRING.comapFlatMap( Range codecs are an implementation of `#flatXMap` which returns an error `DataResult` if the value is not inclusively between the set minimum and maximum. The value is still provided as a partial result if outside the bounds. There are implementations for integers, floats, and doubles via `#intRange`, `#floatRange`, and `#doubleRange` respectively. ```java -public static final Codec RANGE_CODEC = Codec.intRange(0, 4); +public static final Codec RANGE_CODEC = Codec.intRange(0, 4); ``` ```js @@ -431,7 +431,7 @@ public static final Codec = DISPATCH.getCodec() // Gets Codec> = REGISTRAR.register( [Examples][examples] can be found on the Forge Git repository, including silk touch and smelting effects. [tags]: ./tags.md -[resloc]: ../../concepts/resources.md#ResourceLocation +[resloc]: ../../concepts/resources.md#resourcelocation [codec]: #the-loot-modifier-codec [registered]: ../../concepts/registries.md#methods-for-registering [codecdef]: ../../datastorage/codecs.md diff --git a/docs/resources/server/index.md b/docs/resources/server/index.md index bc5b9313..2878d4a3 100644 --- a/docs/resources/server/index.md +++ b/docs/resources/server/index.md @@ -11,4 +11,4 @@ Additional reading: [Resource Locations][resourcelocation] [datapack]: https://minecraft.wiki/w/Data_pack [createdatapack]: https://minecraft.wiki/w/Tutorials/Creating_a_data_pack -[resourcelocation]: ../../concepts/resources.md#ResourceLocation +[resourcelocation]: ../../concepts/resources.md#resourcelocation From 280d6e10b2c9dc5d6944529aae066c4af7091afa Mon Sep 17 00:00:00 2001 From: Kyle VanderBeek Date: Mon, 25 Nov 2024 15:39:42 -0800 Subject: [PATCH 3/4] A composite loader section never existed; remove link. --- docs/rendering/modelextensions/visibility.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/rendering/modelextensions/visibility.md b/docs/rendering/modelextensions/visibility.md index d9a1f71b..b6ef194c 100644 --- a/docs/rendering/modelextensions/visibility.md +++ b/docs/rendering/modelextensions/visibility.md @@ -1,7 +1,7 @@ Part Visibility =============== -Adding the `visibility` entry at the top level of a model JSON allows control over the visibility of different parts of the model to decide whether they should be baked into the final [`BakedModel`][bakedmodel]. The definition of a "part" is dependent on the model loader loading this model and custom model loaders are free to ignore this entry completely. Out of the model loaders provided by Forge only the [composite model loader][composite] and the [OBJ model loader][obj] make use of this functionality. The visibility entries are specified as `"part name": boolean` entries. +Adding the `visibility` entry at the top level of a model JSON allows control over the visibility of different parts of the model to decide whether they should be baked into the final [`BakedModel`][bakedmodel]. The definition of a "part" is dependent on the model loader loading this model and custom model loaders are free to ignore this entry completely. Out of the model loaders provided by Forge only the composite model loader and the [OBJ model loader][obj] make use of this functionality. The visibility entries are specified as `"part name": boolean` entries. Example of a composite model with two parts, the second of which will not be baked into the final model, and two child models overriding this visibility to have only the first part and both parts visible respectively: ```js @@ -48,5 +48,4 @@ This allows setups like the following where multiple models use different parts 3. These child models individually specify different visibilities for the parts [bakedmodel]: ../modelloaders/bakedmodel.md -[composite]: ../modelloaders/index.md/#composite-models -[obj]: ../modelloaders/index.md/#wavefront-obj-models \ No newline at end of file +[obj]: ../modelloaders/index.md/#wavefront-obj-models From 58f4d37738cdead8844b25060665d3326d1aee51 Mon Sep 17 00:00:00 2001 From: Kyle VanderBeek Date: Mon, 25 Nov 2024 15:42:47 -0800 Subject: [PATCH 4/4] Incorrectly formatted link ref --- docs/rendering/modelloaders/bakedmodel.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/rendering/modelloaders/bakedmodel.md b/docs/rendering/modelloaders/bakedmodel.md index 1bc70fbe..c6e53702 100644 --- a/docs/rendering/modelloaders/bakedmodel.md +++ b/docs/rendering/modelloaders/bakedmodel.md @@ -11,7 +11,7 @@ Returns the [`ItemOverrides`][overrides] to use for this model. This is only use ### `useAmbientOcclusion` -If the model is rendered as a block in the level, the block in question does not emit any light, and ambient occlusion is enabled. This causes the model to be rendered with [ambient occlusion](ambocc). +If the model is rendered as a block in the level, the block in question does not emit any light, and ambient occlusion is enabled. This causes the model to be rendered with [ambient occlusion][ambocc]. ### `isGui3d` @@ -43,7 +43,7 @@ See [Transform][transform]. This is the main method of `BakedModel`. It returns a list of `BakedQuad`s: objects which contain the low-level vertex data that will be used to render the model. If the model is being rendered as a block, then the `BlockState` passed in is non-null. If the model is being rendered as an item, the `ItemOverrides` returned from `#getOverrides` is responsible for handling the state of the item, and the `BlockState` parameter will be `null`. -!!! note +!!! note The origin point for the vertices in a `BakedQuad` is the bottom, northwest corner. Vertex coordinate values less than 0 or greater than 1 will position the vertex outside of the block. To avoid lighting issues, provide the vertices in counterclockwise order. The `Direction` passed in is used for face culling. If the block against the given side of another block being rendered is opaque, then the faces associated with that side are not rendered. If that parameter is `null`, all faces not associated with a side are returned (that will never be culled).