New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache downloads for MCP functions. #610

Open

LexManos opened this issue Aug 7, 2019 · 0 comments

Labels

eventually

Member

LexManos commented Aug 7, 2019

In Forge dev, we setup MCP three times, Client/Server/Joined. Each has a download task.
downloadClient
downloadServer
And Joined downloads both.

The downloaded files are cached in the mcp folder for that specific side. Causing it to download the client and server twice.

This also effects setting up a differtn MCP version, for the same MC version.

We need to setup some form of higher level cache for use in these functions. Just to save downloading.

https://github.com/MinecraftForge/ForgeGradle/blob/097dd2a7145a3a4384ffa77876a55fe0b46b6551/src/mcp/java/net/minecraftforge/gradle/mcp/function/AbstractDownloadMCFunction.java

SizableShrimp added the eventually label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment