Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Timeout #3

Open
Kesuaheli opened this issue Oct 11, 2024 · 6 comments
Open

Fetch Timeout #3

Kesuaheli opened this issue Oct 11, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Kesuaheli
Copy link
Member

Kesuaheli commented Oct 11, 2024

Sometimes, the action fails due to a timeout when trying to reach the version manifest from piston-meta.
Here's a failed run:

@Mqxx
Copy link
Member

Mqxx commented Oct 21, 2024

Should be resolved!

@Mqxx Mqxx closed this as completed Oct 21, 2024
@Kesuaheli
Copy link
Member Author

@Mqxx still happening. It just failed (added new workflow link)

@Mqxx Mqxx reopened this Oct 30, 2024
@Mqxx
Copy link
Member

Mqxx commented Oct 30, 2024

Ohh yea, sorry I forgot about that. I moved the Action from Datapack-Registry/minecraft-manifest to MinecraftPlayground/minecraft-manifest. Redirect should still work fine.

I never encountered that error, but it looks like the Mojang API does not respond. A potential solution could be to trigger the job not exactly 00:30 but rather than 00:30 or 01:00. This also gets suggested by the Actions docs, because many users trigger their cron jobs at 00:00.

@Mqxx
Copy link
Member

Mqxx commented Oct 30, 2024

Checkout this workflow: https://github.com/Resourcepack-Registry/data/actions/runs/11585605925/workflow#L4
All of them are using the MinecraftPlayground/minecraft-manifest and they are all passing.

@Kesuaheli
Copy link
Member Author

Kesuaheli commented Nov 4, 2024

Redirect should still work fine.

Yeah, GH has no issue with that. As long as there exists no new repo with that old name, GH redirects any access to the new one.

A potential solution could be to trigger the job not exactly 00:30...

*0:00 (;

...because many users trigger their cron jobs at 00:00.

Ik, and I feel that. Usually, the workflow runs at **:10-**:15. But idc when exactly it runs or how consistent it runs.

I basically made a very simple program that just makes a HEAD request to check if the version manifest endpoint is available. Every 5 seconds.
Unfortunately, it is too simple... and because I'm stupid and can't program, the program ended itself as soon as it got no connection 🤦 Which happened two times.
One at 12:45, and one at 17:20. Both of them ran for 2 hrs (±10 min) and exited with a "connection reset by peer" on a try to read tcp.

@Mqxx
Copy link
Member

Mqxx commented Nov 4, 2024

#5

@Mqxx Mqxx added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants