From 5620463f46eb8ab1e0646354fee9481853a465d8 Mon Sep 17 00:00:00 2001
From: Ekaterina Kazakova <eromanova@mirantis.com>
Date: Thu, 19 Dec 2024 15:58:25 +0400
Subject: [PATCH] Support to skip credentials propagation

---
 api/v1alpha1/managedcluster_types.go                   | 10 ++++++++++
 api/v1alpha1/zz_generated.deepcopy.go                  |  5 +++++
 internal/controller/managedcluster_controller.go       |  8 +++++---
 .../crds/hmc.mirantis.com_managedclusters.yaml         |  6 ++++++
 4 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/api/v1alpha1/managedcluster_types.go b/api/v1alpha1/managedcluster_types.go
index 404a6de1..3841764c 100644
--- a/api/v1alpha1/managedcluster_types.go
+++ b/api/v1alpha1/managedcluster_types.go
@@ -84,6 +84,10 @@ type ManagedClusterSpec struct {
 	// By default the remaining services will be deployed even if conflict is detected.
 	// If set to true, the deployment will stop after encountering the first conflict.
 	StopOnConflict bool `json:"stopOnConflict,omitempty"`
+	// PropagateCredentials indicates whether credentials should be propagated
+	// for use by CCM (Cloud Controller Manager).
+	// Default: true.
+	PropagateCredentials *bool `json:"propagateCredentials,omitempty"`
 }
 
 // ManagedClusterStatus defines the observed state of ManagedCluster
@@ -160,6 +164,12 @@ func (in *ManagedCluster) InitConditions() {
 	})
 }
 
+// PropagateCredentials returns true if credentials should be propagated
+// for use by CCM (Cloud Controller Manager).
+func (in *ManagedCluster) PropagateCredentials() bool {
+	return in.Spec.PropagateCredentials == nil || *in.Spec.PropagateCredentials
+}
+
 // +kubebuilder:object:root=true
 
 // ManagedClusterList contains a list of ManagedCluster
diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
index 059d6037..4fd3da6e 100644
--- a/api/v1alpha1/zz_generated.deepcopy.go
+++ b/api/v1alpha1/zz_generated.deepcopy.go
@@ -744,6 +744,11 @@ func (in *ManagedClusterSpec) DeepCopyInto(out *ManagedClusterSpec) {
 		*out = make([]ServiceSpec, len(*in))
 		copy(*out, *in)
 	}
+	if in.PropagateCredentials != nil {
+		in, out := &in.PropagateCredentials, &out.PropagateCredentials
+		*out = new(bool)
+		**out = **in
+	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new ManagedClusterSpec.
diff --git a/internal/controller/managedcluster_controller.go b/internal/controller/managedcluster_controller.go
index ffb983dc..9e935017 100644
--- a/internal/controller/managedcluster_controller.go
+++ b/internal/controller/managedcluster_controller.go
@@ -354,9 +354,11 @@ func (r *ManagedClusterReconciler) updateCluster(ctx context.Context, mc *hmc.Ma
 		return ctrl.Result{RequeueAfter: DefaultRequeueInterval}, nil
 	}
 
-	if err := r.reconcileCredentialPropagation(ctx, mc); err != nil {
-		l.Error(err, "failed to reconcile credentials propagation")
-		return ctrl.Result{}, err
+	if mc.PropagateCredentials() {
+		if err := r.reconcileCredentialPropagation(ctx, mc); err != nil {
+			l.Error(err, "failed to reconcile credentials propagation")
+			return ctrl.Result{}, err
+		}
 	}
 
 	return ctrl.Result{}, nil
diff --git a/templates/provider/hmc/templates/crds/hmc.mirantis.com_managedclusters.yaml b/templates/provider/hmc/templates/crds/hmc.mirantis.com_managedclusters.yaml
index 8e0ec18a..2f48eb69 100644
--- a/templates/provider/hmc/templates/crds/hmc.mirantis.com_managedclusters.yaml
+++ b/templates/provider/hmc/templates/crds/hmc.mirantis.com_managedclusters.yaml
@@ -69,6 +69,12 @@ spec:
                 description: DryRun specifies whether the template should be applied
                   after validation or only validated.
                 type: boolean
+              propagateCredentials:
+                description: |-
+                  PropagateCredentials indicates whether credentials should be propagated
+                  for use by CCM (Cloud Controller Manager).
+                  Default: true.
+                type: boolean
               services:
                 description: |-
                   Services is a list of services created via ServiceTemplates